Commit graph

621 commits

Author SHA1 Message Date
Richard Hansen
d0fe90ea2c
Merge pull request #229 from ddclient/repology-badge
Add repology.org to readme
2020-07-10 11:55:41 -04:00
Sandro
0b1cc726de Add repology.org to readme 2020-07-10 11:54:34 -04:00
Sandro
64ae58d49b
Merge pull request #240 from rhansen/geturl-unit-tests
Add `geturl` SSL tests
2020-07-08 20:38:06 +02:00
Richard Hansen
dd8e376784 Add geturl SSL tests
These don't test validation, only that IO::Socket::SSL is used.
2020-07-08 13:40:31 -04:00
Sandro
593206ad7d
Merge pull request #248 from rhansen/imports 2020-07-08 12:11:11 +02:00
Richard Hansen
6ff0362450 Get the AF_INET and friends constants from Socket
Apparently it is enough to simply import Socket or IO::Socket to use
AF_INET and friends, but all examples in official documentation show
them in the import list. Because I do not fully understand the
intricacies of Perl import logic, I do the same thing here, fully
aware that I might have joined a cargo cult. Regardless of its
correctness or necessity, listing the constants in the import list has
the advantage of making it clear why the `use` statement exists.

I chose to import the constants from Socket instead of IO::Socket
because that module's documentation explicitly documents the
constants.
2020-07-07 20:55:32 -04:00
Richard Hansen
3b931fb0a6 Add autoconf checks for all used core modules 2020-07-07 16:28:22 -04:00
Sandro
ca1b519444
Merge pull request #238 from rhansen/parse_assignments-subtest
Use `subtest` to group related tests
2020-07-07 20:28:57 +02:00
Richard Hansen
199e9125a4 Use subtest to group related tests
This reduces the output of `make check`, making it easier to zero in
on results of interest.
2020-07-07 13:01:15 -04:00
Richard Hansen
94aaff67cd Add Test::Simple v1.302175 to t/lib
The version of Test::More available in CentOS/RHEL 6 doesn't include
`subtest`, which we want to use. We can revert this commit once we
drop support for CentOS/RHEL 6.

The code is licensed under the same terms as Perl 5 itself:
https://github.com/Test-More/test-more/blob/v1.302175/LICENSE
2020-07-07 13:01:13 -04:00
Sandro
ee4191f865
Merge pull request #225 from reetp/master
Add DinaHosting
2020-07-07 10:15:32 +02:00
Sandro
f0c583890a
Merge pull request #246 from rhansen/unwrap
Unwrap unnecessarily wrapped lines
2020-07-07 10:11:37 +02:00
Sandro
b0b04aa278
Merge pull request #247 from rhansen/parse_assignments
Simplify `parse_assignments`
2020-07-07 10:11:21 +02:00
Sandro
eac5d25e47
Merge pull request #245 from rhansen/continue-on-failure
Don't skip updates to remaining hosts if one host fails
2020-07-07 10:10:42 +02:00
Sandro
9d7af91bf4
Merge pull request #242 from rhansen/mkdir-var-cache 2020-07-07 10:09:47 +02:00
Sandro
666fc293fb
Merge pull request #243 from rhansen/delete-fw-debug
Delete out-of-place debug messages
2020-07-07 10:08:49 +02:00
Sandro
44c92d9992
Merge pull request #244 from rhansen/truthiness
Test for definedness or emptiness, not truthiness
2020-07-07 10:05:59 +02:00
Richard Hansen
71acd749a1 Simplify parse_assignments 2020-07-07 00:10:33 -04:00
Richard Hansen
c3de24bb49 Unwrap unnecessarily wrapped lines 2020-07-07 00:09:44 -04:00
Richard Hansen
bdf8835904 Don't skip updates to remaining hosts if one host fails 2020-07-07 00:08:56 -04:00
Richard Hansen
ee8e1e8844 Don't abort if unable to write the cache file 2020-07-07 00:04:33 -04:00
Richard Hansen
6ae5fe62d7 Create /var/cache/ddclient if it doesn't exist
Fixes #76
2020-07-07 00:04:33 -04:00
Richard Hansen
df3c777e11 Delete out-of-place debug messages
Neither `opt('fw')` nor `$globals{'fw'}` are used in `geturl` so
delete the debug messages showing their values.
2020-07-07 00:03:56 -04:00
John Crisp
e2c3f9dd04 Add support for dinahosting
Fixes #203
2020-07-07 00:00:45 -04:00
Richard Hansen
231306395a Test for definedness or emptiness, not truthiness
Use `//` or `eq ''` for tests to avoid treating the string `'0'` as
false.
2020-07-06 23:58:51 -04:00
Richard Hansen
4670955cb6
Merge pull request #241 from rhansen/get_ip-ssl
Fix detection of `get_ip` caller
2020-07-06 23:56:47 -04:00
Richard Hansen
03dffae74e Honor the ssl option for the web URL 2020-07-06 20:20:01 -04:00
Richard Hansen
7921c53605 Explicitly tell geturl to ignore the global ssl option
Changing behavior based on the identity of the caller is fragile and
makes the code difficult to understand.
2020-07-06 20:19:27 -04:00
Richard Hansen
2e5db5af44 Fix detection of get_ip caller
This was broken in f6f920eb39.
2020-07-06 17:14:08 -04:00
Richard Hansen
4eae0d39a9
Merge pull request #239 from rhansen/perl-core
CentOS/RHEL/Fedora CI improvements
2020-07-06 16:44:28 -04:00
Richard Hansen
f11fef5c50 Install modules for testing on CentOS/RHEL/Fedora 2020-07-06 16:33:26 -04:00
Richard Hansen
1b63ae50c9 Colorize test results 2020-07-06 15:59:30 -04:00
Richard Hansen
5aa4fe71da Pass --refresh to dnf
Hopefully this will stop the "Downloading successful, but checksum
doesn't match" errors we occasionally see for Fedora.
2020-07-06 15:42:41 -04:00
Richard Hansen
34e5cbd97f Rename test-redhat to test-redhat-ubi7 2020-07-06 15:40:42 -04:00
Richard Hansen
ad95fd46c2 Install all core modules on CentOS/RHEL/Fedora
CentOS and RHEL have a `perl-core` metapackage that depends on all
packages providing core modules.

Fedora's `perl` package is equivalent to the CentOS/RHEL `perl-core`
package, and its `perl-interpreter` package is equivalent to the
CentOS/RHEL `perl` package.
2020-07-06 15:24:40 -04:00
Richard Hansen
e621afe375
Merge pull request #231 from ddclient/dead-provider
Remove dead provider
2020-07-06 12:47:55 -04:00
Sandro Jäckel
c8e2adf81a
Add changelog 2020-07-06 15:59:56 +02:00
Sandro Jäckel
b7e7d27a24
Remove dtdns 2020-07-06 15:59:55 +02:00
Sandro Jäckel
12a4a10c9c
Remove hammernode1 2020-07-06 15:57:52 +02:00
Sandro
0600f31d55
Merge pull request #235 from rhansen/geturl-unit-tests
Add `geturl` connectivity unit tests
2020-07-06 00:44:45 +02:00
Richard Hansen
323208e9cc Add geturl connectivity unit tests
Addresses #232
2020-07-05 18:36:46 -04:00
Sandro
b6770a4d9f
Merge pull request #234 from rhansen/url-parsing
Fix URL parsing for IPv6 URLs and pathless URLs
2020-07-06 00:33:22 +02:00
Sandro
cf34c21135
Merge pull request #236 from rhansen/caller-undef-warning
Silence warning when calling `geturl` from an anonymous sub
2020-07-06 00:25:18 +02:00
Richard Hansen
06503a483b Fix URL parsing for IPv6 URLs and pathless URLs
Now the following valid URLs are parsed correctly:
  * http://[::1]:123/foo
  * http://localhost?foo=bar

There are still problems with the URL parsing logic but this is enough
to write some unit tests.
2020-07-05 18:21:35 -04:00
Richard Hansen
49c8717420 Silence warning when calling geturl from an anonymous sub 2020-07-05 18:16:08 -04:00
Sandro
91803cbb41
Merge pull request #237 from rhansen/stringify-ports
Stringify default port numbers
2020-07-05 23:42:26 +02:00
Richard Hansen
a15cec7cd9 Stringify default port numbers
The IO::Socket classes expect strings for the port number because you
can pass service names from `/etc/services`. Numbers work too, but
using strings everywhere makes it easier to write unit tests.
2020-07-05 16:32:41 -04:00
Sandro
d79519f59c
Merge pull request #230 from rhansen/autoconf-test-find
Require `find` to be installed
2020-07-03 23:46:49 +02:00
Richard Hansen
9b1fc13d40 Require find to be installed 2020-07-03 17:35:11 -04:00
Richard Hansen
f527b7487c
Merge pull request #228 from dkerr64/cleanup
Add missing semicolons and fix incorrect debug message
2020-07-03 17:34:30 -04:00