Commit graph

474 commits

Author SHA1 Message Date
Richard Hansen
b3f2f7029d Whitespace fixes 2020-06-13 11:43:33 -04:00
Sandro
38bec6d135
Merge pull request #171 from rhansen/iproute2
Prefer `ip` command from iproute2 over `ifconfig`
2020-06-13 11:23:49 +02:00
Richard Hansen
e3a6cbf1b6 Prefer ip command from iproute2 over ifconfig
On Linux systems, `ifconfig` is long deprecated in favor of the `ip`
command from iproute2. Some systems don't have iproute2 (BSDs in
particular), so ddclient will still attempt `ifconfig` if `ip` is
missing.

Also: Don't hide STDERR because error messages are important for
troubleshooting problems. To avoid STDERR noise on systems without the
`ip` command, the command's existence is checked before it is run.

Notes:
  * The fetched addresses could be limited to IPv4 or IPv6 depending
    on `opt('ipv6')`, and non-global addresses could be filtered out,
    but any filtering risks breaking a nontrivial number of existing
    configurations.
  * This change runs the risk of breaking existing configs that set
    `if-skip`. Due to the deprecation of `ifconfig`, and the belief
    that only a negligible number of users set `if-skip`, the benefits
    of this change are believed to outweigh the config migration
    burden imposed on users.

Fixes #93.
2020-06-12 22:54:49 -04:00
Sandro
20429c1199
Merge pull request #165 from rhansen/multiline-log-space
Remove extra space at beginning of multiline log messages
2020-06-13 00:09:27 +02:00
Richard Hansen
d60a310599 Remove extra space at beginning of multiline log messages 2020-06-12 15:37:30 -04:00
Sandro
eb4b226af0
Merge pull request #153 from rhansen/infer-use 2020-06-12 21:30:16 +02:00
Richard Hansen
e696d57ff2 Prefer ip over if over web when inferring use
If the user passed `-ip` they almost certainly want to use it, even if
they also passed `-if` and `-web`.

Similarly, if the user passed `-if` they almost certainly want to use
it even if they also passed `-web`.
2020-06-12 11:02:48 -04:00
Richard Hansen
1c13c24981 Fix misuse of define() 2020-06-12 11:02:48 -04:00
Sandro
7fa1beb11e
Merge pull request #166 from rhansen/perl-5.10 2020-06-12 12:07:34 +02:00
Richard Hansen
9cd418f79c Bump minimum required Perl to v5.10.1
This allows us to use the `//` and `//=` operators.

v5.10.1 was chosen because that is the oldest version of Perl among
all currently supported releases of Ubuntu, CentOS, RHEL, Fedora, and
Debian.
2020-06-11 23:18:11 -04:00
Richard Hansen
9e672a8c7d
Merge pull request #144 from rhansen/contributing
Start a contributor guide
2020-06-11 23:11:21 -04:00
Richard Hansen
e74797f557 Start a contributor guide
Addreses #122, #129
2020-06-11 23:10:39 -04:00
Richard Hansen
6e8d7e9744
Merge pull request #158 from rhansen/news
Convert RELEASENOTE to a history of notable changes
2020-06-11 23:05:00 -04:00
Richard Hansen
33dc46d8f4 Update ChangeLog.md with recent changes affecting compatibility 2020-06-11 15:33:27 -04:00
Richard Hansen
17707b0cba Note when Data::Validate::IP dependency was added 2020-06-11 15:33:27 -04:00
Richard Hansen
a3c8d581fa Combine RELEASENOTE, ChangeLog, Changelog.old into ChangeLog.md
Create a document whose main purpose is to describe notable changes
between released versions. Populate it with the contents of
RELEASENOTE over time and the entries from ChangeLog and
Changelog.old.

For recent releases, the full announcement text can still be found at
https://github.com/ddclient/ddclient/releases
2020-06-11 15:33:27 -04:00
Richard Hansen
593ed1b7a0 Delete unnecessary double quotes
Also minor style cleanups.
2020-06-11 13:04:09 -04:00
Richard Hansen
e6d1d73a4a Whitespace fixes 2020-06-11 13:02:22 -04:00
Richard Hansen
1d78f5fbe3
Merge pull request #155 from rhansen/content-type-header
Fix regex searching for Content-Type header
2020-06-09 15:01:34 -04:00
Richard Hansen
fe3893e26a Fix regex searching for Content-Type header
* Add the `m` modifier because the `$headers` variable can contain
    multiple headers. If `$headers` contains a Content-Type header but
    it is the second or later header then the regex won't match
    without `m`.
  * Add the `i` modifier because RFC 7230 says that header field names
    are case-insensitive.
  * Don't require a space after the colon because RFC 7230 says that
    the space is optional.
2020-06-09 15:00:01 -04:00
Sandro
7d094c0976
Merge pull request #154 from rhansen/geturl-request-newline
Remove extra newline in HTTP request
2020-06-09 14:41:19 +02:00
Richard Hansen
a12004cc4c Remove extra newline in HTTP request
Before, if there were no custom request headers, the request would end
with three newlines instead of two.
2020-06-09 00:22:05 -04:00
Richard Hansen
c995698b7e Revert "Merge pull request #156 from rhansen/news"
This reverts commit 9ab23a8e8c, reversing
changes made to 31902ac1b1.
2020-06-08 21:17:28 -04:00
Sandro
9ab23a8e8c
Merge pull request #156 from rhansen/news
Start a NEWS document for notable changes
2020-06-08 05:54:09 +02:00
Richard Hansen
1d4a154a21 Update NEWS.md with recent changes affecting compatibility 2020-06-07 17:54:42 -04:00
Richard Hansen
80a19539a1 Note when Data::Validate::IP dependency was added 2020-06-07 17:42:15 -04:00
Richard Hansen
1b5b156097 Create NEWS.md, seeded with RELEASENOTE's history
Create a document that describes notable changes between released
versions. Populate it with the contents of RELEASENOTE over time, and
delete RELEASENOTE as it is now redundant. (The full announcements can
still be found at https://github.com/ddclient/ddclient/releases.)

The name NEWS.md was chosen because it is the convention, and because
Debian policy says documents of this nature must be installed at
/usr/share/doc/ddclient/NEWS.gz. For details, see:
https://www.debian.org/doc/debian-policy/ch-docs.html#changelog-files-and-release-notes
2020-06-07 17:13:17 -04:00
Sandro
31902ac1b1
Merge pull request #152 from rhansen/printf-fixes 2020-06-04 22:47:46 +02:00
Richard Hansen
fb033448b2 Fix usage of printf-like functions
* Remove interpolations from the format specifier (in case the
    variable contains a `%` character).
  * Match the number of arguments to the number of `%` substitutions
    in the format specifier.
2020-06-04 15:47:57 -04:00
Richard Hansen
059f8ecbf0 Whitespace fixes 2020-06-04 15:44:24 -04:00
Sandro
9590a85d83
Merge pull request #150 from rhansen/longer-daemon-default
Use a longer default interval if run as ddclientd
2020-06-03 07:09:48 +02:00
Richard Hansen
0444399c0d Use a longer default interval if run as ddclientd
One minute is too short for a default value.

Addresses #149
2020-06-02 22:23:53 -04:00
Sandro
5cd21f7c7e
Merge pull request #145 from rhansen/cleanups
Delete unnecessary semicolons
2020-06-02 02:05:30 +02:00
Sandro
918e9a97b7
Merge pull request #143 from rhansen/delete-concont
Remove `concont` protocol.
2020-06-02 00:12:08 +02:00
Sandro
2ab9afbc79
Merge pull request #92 from xlammertink/ovhsupport
Added OVH DynHost support
2020-06-02 00:08:25 +02:00
Richard Hansen
fd50a9b44c Delete unnecessary semicolons 2020-06-01 15:18:27 -04:00
Richard Hansen
7de450fd58 Remove concont protocol
It is unclear that this protocol is in use anywhere.  See
https://sourceforge.net/p/ddclient/mailman/message/432027/ for some
discussion.

If it turns out that users are still using `concont` we can revert
this change.
2020-05-31 22:52:22 -04:00
xlammertink
5070bd4296 Added OVH DynHost support 2020-05-31 11:29:30 -04:00
Sandro
f4e6e90c38
Merge pull request #142 from rhansen/config-line-format
Expand comment documenting config line format
2020-05-31 07:29:51 +02:00
Richard Hansen
30180edbc4 Expand comment documenting config line format
Eventually we should move this to README.md or something.
2020-05-30 23:49:56 -04:00
Richard Hansen
01a746c773
Merge pull request #138 from rhansen/dyndns-za-net
Replace dydns.za.net with dyndns.za.net
2020-05-30 23:47:54 -04:00
Richard Hansen
08c2b6c5c3 Replace dydns.za.net with dyndns.za.net
dydns.za.net doesn't appear to exist.
2020-05-30 23:45:21 -04:00
Richard Hansen
d65805b84a
Merge pull request #140 from ddclient/fix-interpolation
Fix here doc interpolation
2020-05-30 22:30:04 -04:00
Sandro Jäckel
babbef1544 Fix here doc interpolation 2020-05-30 22:29:17 -04:00
Richard Hansen
6ae69a1ce6
Merge pull request #141 from ddclient/show-debug-ssl
Show debug ssl
2020-05-30 22:23:57 -04:00
Sandro Jäckel
096288ed18 Expand tabs to spaces in vim 2020-05-30 22:19:43 -04:00
Sandro Jäckel
0206262850 Show debug connection settings after evaluating use-ssl
Before this change we often showed http:// in debug log
even when we later connect via https. This is confusing.

Closes #139
2020-05-30 22:19:43 -04:00
hgducharme
cf2693a656
Added NoIP example to sample-etc_ddclient.conf
Closes #51
2020-05-30 05:11:08 +02:00
Sandro
afba2f375e
Merge pull request #127 from rhansen/delete-unused-varargs
Delete unused varargs from _read_config and parse_assignment(s)
2020-05-29 10:55:31 +02:00
Sandro
104c3245ce
Merge pull request #133 from rhansen/pid-only-if-daemonized
Only write the PID file if daemonized
2020-05-29 10:51:56 +02:00