Fabio/ddclient
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #245 from rhansen/continue-on-failure

Browse source 
Don't skip updates to remaining hosts if one host fails
This commit is contained in:
Sandro 2020-07-07 10:10:42 +02:00 committed by GitHub
commit eac5d25e47
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 41 additions and 41 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
ChangeLog.md
View file

@ -21,10 +21,10 @@ repository history](https://github.com/ddclient/ddclient/commits/master).
### Bug fixes ### Bug fixes
* Minor `freedns` protocol fixes, including: * If multiple hosts are defined and one fails, ddclient will no longer skip
* You can now update an address that differs from the system's own. the remaining hosts.
* If multiple hosts are defined and one fails, ddclient will no longer * Minor `freedns` protocol fixes. In particular, you can now update an
skip the remaining hosts. address that differs from the system's own.
* Fixed a regression introduced in v3.9.0 that caused * Fixed a regression introduced in v3.9.0 that caused
`use=ip,ip=<ipv4-address>` to fail. `use=ip,ip=<ipv4-address>` to fail.
* "true" is now accepted as a boolean value. * "true" is now accepted as a boolean value.

74
ddclient.in
View file

@ -2629,7 +2629,7 @@ sub nic_dyndns1_update {
failed("updating %s: Could not connect to %s.", $h, $config{$h}{'server'}); failed("updating %s: Could not connect to %s.", $h, $config{$h}{'server'});
next; next;
} }
last if !header_ok($h, $reply); next if !header_ok($h, $reply);
my @reply = split /\n/, $reply; my @reply = split /\n/, $reply;
my ($title, $return_code, $error_code) = ('', '', ''); my ($title, $return_code, $error_code) = ('', '', '');
@ -2795,9 +2795,9 @@ sub nic_dyndns2_update {
}) // ''; }) // '';
if ($reply eq '') { if ($reply eq '') {
failed("updating %s: Could not connect to %s.", $hosts, $config{$h}{'server'}); failed("updating %s: Could not connect to %s.", $hosts, $config{$h}{'server'});
last; next;
} }
last if !header_ok($hosts, $reply); next if !header_ok($hosts, $reply);
my @reply = split /\n/, $reply; my @reply = split /\n/, $reply;
my $state = 'header'; my $state = 'header';
@ -2905,9 +2905,9 @@ sub nic_noip_update {
}) // ''; }) // '';
if ($reply eq '') { if ($reply eq '') {
failed("updating %s: Could not connect to %s.", $hosts, $config{$h}{'server'}); failed("updating %s: Could not connect to %s.", $hosts, $config{$h}{'server'});
last; next;
} }
last if !header_ok($hosts, $reply); next if !header_ok($hosts, $reply);
my @reply = split /\n/, $reply; my @reply = split /\n/, $reply;
my $state = 'header'; my $state = 'header';
@ -3146,9 +3146,9 @@ sub nic_zoneedit1_update {
}) // ''; }) // '';
if ($reply eq '') { if ($reply eq '') {
failed("updating %s: Could not connect to %s.", $hosts, $config{$h}{'server'}); failed("updating %s: Could not connect to %s.", $hosts, $config{$h}{'server'});
last; next;
} }
last if !header_ok($hosts, $reply); next if !header_ok($hosts, $reply);
my @reply = split /\n/, $reply; my @reply = split /\n/, $reply;
foreach my $line (@reply) { foreach my $line (@reply) {
@ -3301,9 +3301,9 @@ sub nic_easydns_update {
}) // ''; }) // '';
if ($reply eq '') { if ($reply eq '') {
failed("updating %s: Could not connect to %s.", $hosts, $config{$h}{'server'}); failed("updating %s: Could not connect to %s.", $hosts, $config{$h}{'server'});
last; next;
} }
last if !header_ok($hosts, $reply); next if !header_ok($hosts, $reply);
my @reply = split /\n/, $reply; my @reply = split /\n/, $reply;
my $state = 'header'; my $state = 'header';
@ -3415,9 +3415,9 @@ sub nic_namecheap_update {
my $reply = geturl({ proxy => opt('proxy'), url => $url }) // ''; my $reply = geturl({ proxy => opt('proxy'), url => $url }) // '';
if ($reply eq '') { if ($reply eq '') {
failed("updating %s: Could not connect to %s.", $h, $config{$h}{'server'}); failed("updating %s: Could not connect to %s.", $h, $config{$h}{'server'});
last; next;
} }
last if !header_ok($h, $reply); next if !header_ok($h, $reply);
my @reply = split /\n/, $reply; my @reply = split /\n/, $reply;
if (grep /<ErrCount>0/i, @reply) { if (grep /<ErrCount>0/i, @reply) {
@ -3725,9 +3725,9 @@ sub nic_sitelutions_update {
my $reply = geturl({ proxy => opt('proxy'), url => $url }); my $reply = geturl({ proxy => opt('proxy'), url => $url });
if (!defined($reply) || !$reply) { if (!defined($reply) || !$reply) {
failed("updating %s: Could not connect to %s.", $h, $config{$h}{'server'}); failed("updating %s: Could not connect to %s.", $h, $config{$h}{'server'});
last; next;
} }
last if !header_ok($h, $reply); next if !header_ok($h, $reply);
my @reply = split /\n/, $reply; my @reply = split /\n/, $reply;
if (grep /success/i, @reply) { if (grep /success/i, @reply) {
@ -3940,9 +3940,9 @@ sub nic_changeip_update {
}); });
if (!defined($reply) || !$reply) { if (!defined($reply) || !$reply) {
failed("updating %s: Could not connect to %s.", $h, $config{$h}{'server'}); failed("updating %s: Could not connect to %s.", $h, $config{$h}{'server'});
last; next;
} }
last if !header_ok($h, $reply); next if !header_ok($h, $reply);
my @reply = split /\n/, $reply; my @reply = split /\n/, $reply;
if (grep /success/i, @reply) { if (grep /success/i, @reply) {
@ -4027,9 +4027,9 @@ sub nic_googledomains_update {
}); });
unless ($reply) { unless ($reply) {
failed("updating %s: Could not connect to %s.", $host, $config{$host}{'server'}); failed("updating %s: Could not connect to %s.", $host, $config{$host}{'server'});
last; next;
} }
last if !header_ok($host, $reply); next if !header_ok($host, $reply);
# Cache # Cache
$config{$host}{'ip'} = $ip; $config{$host}{'ip'} = $ip;
@ -4236,9 +4236,9 @@ sub nic_cloudflare_update {
my $reply = geturl({ proxy => opt('proxy'), url => $url, headers => $headers }); my $reply = geturl({ proxy => opt('proxy'), url => $url, headers => $headers });
unless ($reply) { unless ($reply) {
failed("updating %s: Could not connect to %s.", $domain, $config{$key}{'server'}); failed("updating %s: Could not connect to %s.", $domain, $config{$key}{'server'});
last; next;
} }
last if !header_ok($domain, $reply); next if !header_ok($domain, $reply);
# Strip header # Strip header
$reply =~ s/^.*?\n\n//s; $reply =~ s/^.*?\n\n//s;
@ -4267,9 +4267,9 @@ sub nic_cloudflare_update {
$reply = geturl({ proxy => opt('proxy'), url => $url, headers => $headers }); $reply = geturl({ proxy => opt('proxy'), url => $url, headers => $headers });
unless ($reply) { unless ($reply) {
failed("updating %s: Could not connect to %s.", $domain, $config{$key}{'server'}); failed("updating %s: Could not connect to %s.", $domain, $config{$key}{'server'});
last; next;
} }
last if !header_ok($domain, $reply); next if !header_ok($domain, $reply);
# Strip header # Strip header
$reply =~ s/^.*?\n\n//s; $reply =~ s/^.*?\n\n//s;
@ -4299,9 +4299,9 @@ sub nic_cloudflare_update {
}); });
unless ($reply) { unless ($reply) {
failed("updating %s: Could not connect to %s.", $domain, $config{$domain}{'server'}); failed("updating %s: Could not connect to %s.", $domain, $config{$domain}{'server'});
last; next;
} }
last if !header_ok($domain, $reply); next if !header_ok($domain, $reply);
# Strip header # Strip header
$reply =~ s/^.*?\n\n//s; $reply =~ s/^.*?\n\n//s;
@ -4383,9 +4383,9 @@ sub nic_yandex_update {
my $reply = geturl({ proxy => opt('proxy'), url => $url, headers => $headers }); my $reply = geturl({ proxy => opt('proxy'), url => $url, headers => $headers });
unless ($reply) { unless ($reply) {
failed("updating %s: Could not connect to %s.", $host, $config{$key}{'server'}); failed("updating %s: Could not connect to %s.", $host, $config{$key}{'server'});
last; next;
} }
last if !header_ok($host, $reply); next if !header_ok($host, $reply);
# Strip header # Strip header
$reply =~ s/^.*?\n\n//s; $reply =~ s/^.*?\n\n//s;
@ -4420,9 +4420,9 @@ sub nic_yandex_update {
}); });
unless ($reply) { unless ($reply) {
failed("updating %s: Could not connect to %s.", $host, $config{$host}{'server'}); failed("updating %s: Could not connect to %s.", $host, $config{$host}{'server'});
last; next;
} }
last if !header_ok($host, $reply); next if !header_ok($host, $reply);
# Strip header # Strip header
$reply =~ s/^.*?\n\n//s; $reply =~ s/^.*?\n\n//s;
@ -4500,9 +4500,9 @@ sub nic_duckdns_update {
# No response, declare as failed # No response, declare as failed
if (!defined($reply) || !$reply) { if (!defined($reply) || !$reply) {
failed("updating %s: Could not connect to %s.", $h, $config{$h}{'server'}); failed("updating %s: Could not connect to %s.", $h, $config{$h}{'server'});
last; next;
} }
last if !header_ok($h, $reply); next if !header_ok($h, $reply);
my @reply = split /\n/, $reply; my @reply = split /\n/, $reply;
my $returned = pop(@reply); my $returned = pop(@reply);
@ -4571,9 +4571,9 @@ sub nic_freemyip_update {
# No response, declare as failed # No response, declare as failed
if (!defined($reply) || !$reply) { if (!defined($reply) || !$reply) {
failed("updating %s: Could not connect to %s.", $h, $config{$h}{'server'}); failed("updating %s: Could not connect to %s.", $h, $config{$h}{'server'});
last; next;
} }
last if !header_ok($h, $reply); next if !header_ok($h, $reply);
my @reply = split /\n/, $reply; my @reply = split /\n/, $reply;
my $returned = pop(@reply); my $returned = pop(@reply);
@ -4700,9 +4700,9 @@ sub nic_woima_update {
}); });
if (!defined($reply) || !$reply) { if (!defined($reply) || !$reply) {
failed("updating %s: Could not connect to %s.", $h, $config{$h}{'server'}); failed("updating %s: Could not connect to %s.", $h, $config{$h}{'server'});
last; next;
} }
last if !header_ok($h, $reply); next if !header_ok($h, $reply);
my @reply = split /\n/, $reply; my @reply = split /\n/, $reply;
my $state = 'header'; my $state = 'header';
@ -4818,9 +4818,9 @@ sub nic_dondominio_update {
# No response, declare as failed # No response, declare as failed
if (!defined($reply) || !$reply) { if (!defined($reply) || !$reply) {
failed("updating %s: Could not connect to %s.", $h, $config{$h}{'server'}); failed("updating %s: Could not connect to %s.", $h, $config{$h}{'server'});
last; next;
} }
last if !header_ok($h, $reply); next if !header_ok($h, $reply);
my @reply = split /\n/, $reply; my @reply = split /\n/, $reply;
my $returned = pop(@reply); my $returned = pop(@reply);
@ -4904,9 +4904,9 @@ sub nic_dnsmadeeasy_update {
# No response, declare as failed # No response, declare as failed
if (!defined($reply) || !$reply) { if (!defined($reply) || !$reply) {
failed("Updating %s: Could not connect to %s.", $h, $config{$h}{'server'}); failed("Updating %s: Could not connect to %s.", $h, $config{$h}{'server'});
last; next;
} }
last if !header_ok($h, $reply); next if !header_ok($h, $reply);
my @reply = split /\n/, $reply; my @reply = split /\n/, $reply;
my $returned = pop(@reply); my $returned = pop(@reply);