refactor: light refactoring

This commit is contained in:
Bill Church 2022-05-20 15:12:01 -04:00
parent 0dcaa6e150
commit e75392b879
2 changed files with 9 additions and 7 deletions

View file

@ -20,7 +20,7 @@ const session = require('express-session')(config.express);
const appSocket = require('./socket');
const { setDefaultCredentials, basicAuth } = require('./util');
const { webssh2debug, auditLog, logError } = require('./logging');
const { webssh2debug } = require('./logging');
const { reauth, connect, notfound, handleErrors } = require('./routes');
setDefaultCredentials(config);

View file

@ -11,10 +11,12 @@ const config = require('./config');
exports.reauth = function reauth(req, res) {
let { referer } = req.headers;
console.log(`referer: ${referer}`);
if (!validator.isURL(referer, { host_whitelist: ['localhost'] })) referer = '/';
console.log(`referer: ${referer}`);
if (!validator.isURL(referer, { host_whitelist: ['localhost'] })) {
console.error(
`WebSSH2 (${req.sessionID}) ERROR: Referrer '${referer}' for '/reauth' invalid. Setting to '/' which will probably fail.`
);
referer = '/';
}
res
.status(401)
.send(
@ -87,11 +89,11 @@ exports.connect = function connect(req, res) {
if (req.session.ssh.header.background) validator.escape(req.session.ssh.header.background);
};
exports.notfound = function notfound(req, res) {
exports.notfound = function notfound(_req, res) {
res.status(404).send("Sorry, can't find that!");
};
exports.handleErrors = function handleErrors(err, req, res) {
exports.handleErrors = function handleErrors(err, _req, res) {
console.error(err.stack);
res.status(500).send('Something broke!');
};