Fabio/webssh2
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

chore: fix some misplaced next returns in some Express routes #242

Browse source
This commit is contained in:
Bill Church 2021-05-17 06:42:58 -04:00
parent b612304dea
commit 3d7e1d68cd
1 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
app/server/app.js
View file

@ -164,10 +164,9 @@ app.use('/ssh', express.static(publicPath, expressOptions));
// favicon from root if being pre-fetched by browser to prevent a 404 // favicon from root if being pre-fetched by browser to prevent a 404
app.use(favicon(path.join(publicPath, 'favicon.ico'))); app.use(favicon(path.join(publicPath, 'favicon.ico')));
app.get('/ssh/reauth', (req, res, next) => { app.get('/ssh/reauth', (req, res) => {
const r = req.headers.referer || '/'; const r = req.headers.referer || '/';
res.status(401).send(`<!DOCTYPE html><html><head><meta http-equiv="refresh" content="0; url=${r}"></head><body bgcolor="#000"></body></html>`); res.status(401).send(`<!DOCTYPE html><html><head><meta http-equiv="refresh" content="0; url=${r}"></head><body bgcolor="#000"></body></html>`);
next();
}); });
// eslint-disable-next-line complexity // eslint-disable-next-line complexity
@ -214,15 +213,13 @@ app.get('/ssh/host/:host?', (req, res) => {
}); });
// express error handling // express error handling
app.use((req, res, next) => { app.use((req, res) => {
res.status(404).send("Sorry, can't find that!"); res.status(404).send("Sorry, can't find that!");
next();
}); });
app.use((err, req, res, next) => { app.use((err, req, res) => {
console.error(err.stack); console.error(err.stack);
res.status(500).send('Something broke!'); res.status(500).send('Something broke!');
next();
}); });
// bring up socket // bring up socket