From e36e38f166ac75c48aa0902d84dcb637dce1a374 Mon Sep 17 00:00:00 2001 From: Mike Dillon Date: Sat, 17 Oct 2015 16:06:51 -0700 Subject: [PATCH] Trim $host and $proto before they're used --- nginx.tmpl | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/nginx.tmpl b/nginx.tmpl index 255cc35..0744941 100644 --- a/nginx.tmpl +++ b/nginx.tmpl @@ -72,6 +72,8 @@ server { {{ range $host, $containers := groupByMulti $ "Env.VIRTUAL_HOST" "," }} +{{ $host := trim $host }} + upstream {{ $host }} { {{ range $container := $containers }} {{ $addrLen := len $container.Addresses }} @@ -92,7 +94,7 @@ upstream {{ $host }} { {{ $default_server := index (dict $host "" $default_host "default_server") $host }} {{/* Get the VIRTUAL_PROTO defined by containers w/ the same vhost, falling back to "http" */}} -{{ $proto := or (first (groupByKeys $containers "Env.VIRTUAL_PROTO")) "http" }} +{{ $proto := or (trim (first (groupByKeys $containers "Env.VIRTUAL_PROTO"))) "http" }} {{/* Get the first cert name defined by containers w/ the same vhost */}} {{ $certName := (first (groupByKeys $containers "Env.CERT_NAME")) }} @@ -144,7 +146,7 @@ server { {{ end }} location / { - proxy_pass {{ trim $proto }}://{{ trim $host }}; + proxy_pass {{ $proto }}://{{ $host }}; {{ if (exists (printf "/etc/nginx/htpasswd/%s" $host)) }} auth_basic "Restricted {{ $host }}"; auth_basic_user_file {{ (printf "/etc/nginx/htpasswd/%s" $host) }}; @@ -170,7 +172,7 @@ server { {{ end }} location / { - proxy_pass {{ trim $proto }}://{{ trim $host }}; + proxy_pass {{ $proto }}://{{ $host }}; {{ if (exists (printf "/etc/nginx/htpasswd/%s" $host)) }} auth_basic "Restricted {{ $host }}"; auth_basic_user_file {{ (printf "/etc/nginx/htpasswd/%s" $host) }};