From b6808165052c7405842cc17783060a3dc5b16509 Mon Sep 17 00:00:00 2001 From: Sami Jawhar Date: Wed, 8 Feb 2017 16:39:54 -0800 Subject: [PATCH 1/2] Compose v3: Moved shared volume to top-level volumes entry For compatibility for Docker Compose v3, replaced the unnamed volume in the nginx service with a named nginx_conf volume that is shared by both services. --- docker-compose-separate-containers.yml | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/docker-compose-separate-containers.yml b/docker-compose-separate-containers.yml index a4edb94..18b1e46 100644 --- a/docker-compose-separate-containers.yml +++ b/docker-compose-separate-containers.yml @@ -1,4 +1,4 @@ -version: '2' +version: '3' services: nginx: image: nginx @@ -6,18 +6,20 @@ services: ports: - "80:80" volumes: - - /etc/nginx/conf.d + - nginx_conf:/etc/nginx/conf.d dockergen: image: jwilder/docker-gen command: -notify-sighup nginx -watch /etc/docker-gen/templates/nginx.tmpl /etc/nginx/conf.d/default.conf - volumes_from: - - nginx volumes: - /var/run/docker.sock:/tmp/docker.sock:ro - ./nginx.tmpl:/etc/docker-gen/templates/nginx.tmpl + - nginx_conf:/etc/nginx/conf.d whoami: image: jwilder/whoami environment: - VIRTUAL_HOST=whoami.local + +volumes: + nginx_conf: {} From d85c033f6166246ca15f28c51c18e957dcb51131 Mon Sep 17 00:00:00 2001 From: Sami Jawhar Date: Wed, 12 Apr 2017 05:39:35 -0700 Subject: [PATCH 2/2] Set compose file version back to 2.1 for separate containers --- docker-compose-separate-containers.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docker-compose-separate-containers.yml b/docker-compose-separate-containers.yml index 18b1e46..90230e0 100644 --- a/docker-compose-separate-containers.yml +++ b/docker-compose-separate-containers.yml @@ -1,4 +1,4 @@ -version: '3' +version: '2.1' services: nginx: image: nginx