Fabio/hassio-supervised-installer
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Prevent blind overwrite of user's configuration

Browse source 
Just as it happens for the `/etc/network/interfaces` it would be more polite to actually ask the user if they want to overwride their `/etc/NetworkManager/NetworkManager.conf`.
Changing this file by force will most likely shut a user out of their PI, because of wifi MAC address randomization, which is hardly the expected behavior from an install script.
__Those choosing to use this install script do it to keep control over their machine, which includes avoiding unexpected deletion of their config files.__

For instance, things work just fine for me with the following `NetworkManager.sh`:
```
[main]
plugins=ifupdown,keyfile

[ifupdown]
managed=false

[device]
wifi.scan-rand-mac-address=no
```

If something out of the downloaded `NetworkManager.sh` is actually mandatory (doesn't seem so tho) It's would be better di explicitly explain it to the user so their can take actions, rather than causing them unexpected behaviors.
This commit is contained in:
Luciano Colosio 2021-06-11 17:26:56 +02:00 committed by GitHub
parent 5fa7341d9c
commit c6f5a1bb27
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
installer.sh
View file

@ -95,20 +95,31 @@ if [[ "$(sysctl --values kernel.dmesg_restrict)" != "0" ]]; then
fi fi
# Create config for NetworkManager # Create config for NetworkManager
info "Creating NetworkManager configuration" warn "Changes are needed to the /etc/NetworkManager/ config files"
curl -sL "${URL_NM_CONF}" > "${FILE_NM_CONF}" info "If you have modified the NetworkManager on the host manualy, those can now be overwritten"
if [ ! -f "$FILE_NM_CONNECTION" ]; then info "If you choose to overwrite it your current file will be saved as /etc/NetworkManager/NetworkManager.conf.ha_bck"
curl -sL "${URL_NM_CONNECTION}" > "${FILE_NM_CONNECTION}" warn "If you are a raspian user beware this might cause your wifi MAC address to be randomized, possibily making it difficult to ssh back to your pi"
info "Do you want to proceed with overwriting the /etc/NetworkManager/NetworkManager.conf file? [N/y] "
read nmanswer < /dev/tty
if [[ "$nmanswer" =~ "y" ]] || [[ "$nmanswer" =~ "Y" ]]; then
info "Creating NetworkManager configuration"
cp "${FILE_NM_CONF}" "${FILE_NM_CONF}.ha_bck"
curl -sL "${URL_NM_CONF}" > "${FILE_NM_CONF}"
if [ ! -f "$FILE_NM_CONNECTION" ]; then
curl -sL "${URL_NM_CONNECTION}" > "${FILE_NM_CONNECTION}"
fi
fi fi
warn "Changes are needed to the /etc/network/interfaces file" warn "Changes are needed to the /etc/network/interfaces file"
info "If you have modified the network on the host manualy, those can now be overwritten" info "If you have modified the network on the host manualy, those can now be overwritten"
info "If you do not overwrite this now you need to manually adjust it later" info "If you do not overwrite this now you need to manually adjust it later"
info "If you choose to overwrite it your current file will be saved as /etc/network/interfaces.ha_bck"
info "Do you want to proceed with overwriting the /etc/network/interfaces file? [N/y] " info "Do you want to proceed with overwriting the /etc/network/interfaces file? [N/y] "
read answer < /dev/tty read answer < /dev/tty
if [[ "$answer" =~ "y" ]] || [[ "$answer" =~ "Y" ]]; then if [[ "$answer" =~ "y" ]] || [[ "$answer" =~ "Y" ]]; then
info "Replacing /etc/network/interfaces" info "Replacing /etc/network/interfaces"
cp "${FILE_INTERFACES}" "${FILE_INTERFACES}.ha_bck"
curl -sL "${URL_INTERFACES}" > "${FILE_INTERFACES}"; curl -sL "${URL_INTERFACES}" > "${FILE_INTERFACES}";
fi fi