add missing parameter and rename

This commit is contained in:
vcoppe 2024-08-22 12:54:59 +02:00
parent 91fa50b22c
commit 7db43d3e35

View file

@ -100,8 +100,8 @@ export function getTemperatureWithUnits(value: number, convert: boolean = true)
} }
// Get the units // Get the units
export function getDistanceUnits(currentDistanceUnits = get(distanceUnits)) { export function getDistanceUnits(targetDistanceUnits = get(distanceUnits)) {
switch (currentDistanceUnits) { switch (targetDistanceUnits) {
case 'metric': case 'metric':
return get(_)('units.kilometers'); return get(_)('units.kilometers');
case 'imperial': case 'imperial':
@ -111,9 +111,9 @@ export function getDistanceUnits(currentDistanceUnits = get(distanceUnits)) {
} }
} }
export function getVelocityUnits(currentVelocityUnits = get(velocityUnits), currentDistanceUnits = get(distanceUnits)) { export function getVelocityUnits(targetVelocityUnits = get(velocityUnits), targetDistanceUnits = get(distanceUnits)) {
if (currentVelocityUnits === 'speed') { if (targetVelocityUnits === 'speed') {
switch (currentDistanceUnits) { switch (targetDistanceUnits) {
case 'metric': case 'metric':
return get(_)('units.kilometers_per_hour'); return get(_)('units.kilometers_per_hour');
case 'imperial': case 'imperial':
@ -122,7 +122,7 @@ export function getVelocityUnits(currentVelocityUnits = get(velocityUnits), curr
return get(_)('units.knots'); return get(_)('units.knots');
} }
} else { } else {
switch (currentDistanceUnits) { switch (targetDistanceUnits) {
case 'metric': case 'metric':
return get(_)('units.minutes_per_kilometer'); return get(_)('units.minutes_per_kilometer');
case 'imperial': case 'imperial':
@ -133,8 +133,8 @@ export function getVelocityUnits(currentVelocityUnits = get(velocityUnits), curr
} }
} }
export function getElevationUnits(currentDistanceUnits = get(distanceUnits)) { export function getElevationUnits(targetDistanceUnits = get(distanceUnits)) {
return currentDistanceUnits === 'metric' ? get(_)('units.meters') : get(_)('units.feet'); return targetDistanceUnits === 'metric' ? get(_)('units.meters') : get(_)('units.feet');
} }
export function getHeartRateUnits() { export function getHeartRateUnits() {
@ -154,8 +154,8 @@ export function getTemperatureUnits() {
} }
// Convert only the value // Convert only the value
export function getConvertedDistance(value: number, currentDistanceUnits = get(distanceUnits)) { export function getConvertedDistance(value: number, targetDistanceUnits = get(distanceUnits)) {
switch (currentDistanceUnits) { switch (targetDistanceUnits) {
case 'metric': case 'metric':
return value; return value;
case 'imperial': case 'imperial':
@ -165,13 +165,13 @@ export function getConvertedDistance(value: number, currentDistanceUnits = get(d
} }
} }
export function getConvertedElevation(value: number) { export function getConvertedElevation(value: number, targetDistanceUnits = get(distanceUnits)) {
return get(distanceUnits) === 'metric' ? value : metersToFeet(value); return targetDistanceUnits === 'metric' ? value : metersToFeet(value);
} }
export function getConvertedVelocity(value: number, currentVelocityUnits = get(velocityUnits), currentDistanceUnits = get(distanceUnits)) { export function getConvertedVelocity(value: number, targetVelocityUnits = get(velocityUnits), targetDistanceUnits = get(distanceUnits)) {
if (currentVelocityUnits === 'speed') { if (targetVelocityUnits === 'speed') {
switch (currentDistanceUnits) { switch (targetDistanceUnits) {
case 'metric': case 'metric':
return value; return value;
case 'imperial': case 'imperial':
@ -180,7 +180,7 @@ export function getConvertedVelocity(value: number, currentVelocityUnits = get(v
return kilometersToNauticalMiles(value); return kilometersToNauticalMiles(value);
} }
} else { } else {
switch (currentDistanceUnits) { switch (targetDistanceUnits) {
case 'metric': case 'metric':
return distancePerHourToSecondsPerDistance(value); return distancePerHourToSecondsPerDistance(value);
case 'imperial': case 'imperial':