From 60f93dfe48cdcc2fd1c9c89cef665c7b0892067e Mon Sep 17 00:00:00 2001
From: Maksim <18454392+silentdigit@users.noreply.github.com>
Date: Tue, 10 Dec 2019 09:04:16 +1100
Subject: [PATCH] progress towards making email an optional parameter

---
 scripts/cert.sh  | 3 +++
 scripts/start.sh | 9 ++++-----
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/scripts/cert.sh b/scripts/cert.sh
index c16c719..496707e 100755
--- a/scripts/cert.sh
+++ b/scripts/cert.sh
@@ -1,5 +1,8 @@
 #!/bin/sh
 
+# TODO: Make email an optional parameter
+# Check what happens when both -m and registration without email are supplied
+
 # Initial check for certificates
 certbot certonly --manual --preferred-challenges dns --manual-auth-hook \
   /scripts/auth.sh --manual-cleanup-hook /scripts/cleanup.sh \
diff --git a/scripts/start.sh b/scripts/start.sh
index fe0fbe2..e70d277 100755
--- a/scripts/start.sh
+++ b/scripts/start.sh
@@ -11,16 +11,15 @@ if [ -z "$DUCKDNS_DOMAIN" ]; then
 	exit 1
 fi
 
-if [ -z "$LETSENCRYPT_EMAIL" ]; then
-	echo ERROR: Variable LETSENCRYPT_EMAIL is unset
-	exit 1
-fi
-
 if [ -z "$LETSENCRYPT_WILDCARD" ]; then
 	echo ERROR: Variable LETSENCRYPT_WILDCARD is unset
 	exit 1
 fi
 
+if [ -z "$LETSENCRYPT_EMAIL" ]; then
+	echo NOTICE: You will not receive SSL certificate expiration notices
+fi
+
 # Set certificate url based on LETSENCRYPT_WILDCARD value
 if [ "$LETSENCRYPT_WILDCARD" = "true" ]; then
   export LETSENCRYPT_DOMAIN=*.${DUCKDNS_DOMAIN}