Fabio/ddclient
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
1153 commits 2 branches 15 tags 3.5 MiB
Commit graph

396 commits

Author SHA1 Message Date
Richard Hansen
286fe02478 Fix -daemon command-line argument parsing 
It turns out the logic removed in
d10601de11 had a purpose after all.
 2020-07-14 23:17:19 -04:00
Richard Hansen
7d58f2d749 Import IO::Socket::INET 
We've always required IO::Socket::INET but never explicitly included
it. For some reason that hasn't been a problem until now.

Fixes #255
 2020-07-12 18:58:31 -04:00
Richard Hansen
5f1dacc3bd Eliminate unnecessary hashref 
Pass the key-value pairs directly instead of via a hashref.
 2020-07-11 21:39:48 -04:00
David Kerr
29202f5bc1 New is_ipv6 and extract_ipv6 algorithms 
Also add unit tests.
 2020-07-11 11:04:47 -04:00
David Kerr
92c1294af9 Accept leading zeros in IPv4 addresses 
Also add unit tests.
 2020-07-11 11:04:33 -04:00
Richard Hansen
dd8e376784 Add geturl SSL tests 
These don't test validation, only that IO::Socket::SSL is used.
 2020-07-08 13:40:31 -04:00
Richard Hansen
6ff0362450 Get the AF_INET and friends constants from Socket 
Apparently it is enough to simply import Socket or IO::Socket to use
AF_INET and friends, but all examples in official documentation show
them in the import list. Because I do not fully understand the
intricacies of Perl import logic, I do the same thing here, fully
aware that I might have joined a cargo cult. Regardless of its
correctness or necessity, listing the constants in the import list has
the advantage of making it clear why the `use` statement exists.

I chose to import the constants from Socket instead of IO::Socket
because that module's documentation explicitly documents the
constants.
 2020-07-07 20:55:32 -04:00
Sandro
ee4191f865
Merge pull request #225 from reetp/master 
Add DinaHosting
 2020-07-07 10:15:32 +02:00
Sandro
f0c583890a
Merge pull request #246 from rhansen/unwrap 
Unwrap unnecessarily wrapped lines
 2020-07-07 10:11:37 +02:00
Sandro
b0b04aa278
Merge pull request #247 from rhansen/parse_assignments 
Simplify `parse_assignments`
 2020-07-07 10:11:21 +02:00
Sandro
eac5d25e47
Merge pull request #245 from rhansen/continue-on-failure 
Don't skip updates to remaining hosts if one host fails
 2020-07-07 10:10:42 +02:00
Sandro
9d7af91bf4
Merge pull request #242 from rhansen/mkdir-var-cache 2020-07-07 10:09:47 +02:00
Sandro
666fc293fb
Merge pull request #243 from rhansen/delete-fw-debug 
Delete out-of-place debug messages
 2020-07-07 10:08:49 +02:00
Richard Hansen
71acd749a1 Simplify parse_assignments 2020-07-07 00:10:33 -04:00
Richard Hansen
c3de24bb49 Unwrap unnecessarily wrapped lines 2020-07-07 00:09:44 -04:00
Richard Hansen
bdf8835904 Don't skip updates to remaining hosts if one host fails 2020-07-07 00:08:56 -04:00
Richard Hansen
ee8e1e8844 Don't abort if unable to write the cache file 2020-07-07 00:04:33 -04:00
Richard Hansen
6ae5fe62d7 Create /var/cache/ddclient if it doesn't exist 
Fixes #76
 2020-07-07 00:04:33 -04:00
Richard Hansen
df3c777e11 Delete out-of-place debug messages 
Neither `opt('fw')` nor `$globals{'fw'}` are used in `geturl` so
delete the debug messages showing their values.
 2020-07-07 00:03:56 -04:00
John Crisp
e2c3f9dd04 Add support for dinahosting 
Fixes #203
 2020-07-07 00:00:45 -04:00
Richard Hansen
231306395a Test for definedness or emptiness, not truthiness 
Use `//` or `eq ''` for tests to avoid treating the string `'0'` as
false.
 2020-07-06 23:58:51 -04:00
Richard Hansen
03dffae74e Honor the ssl option for the web URL 2020-07-06 20:20:01 -04:00
Richard Hansen
7921c53605 Explicitly tell geturl to ignore the global ssl option 
Changing behavior based on the identity of the caller is fragile and
makes the code difficult to understand.
 2020-07-06 20:19:27 -04:00
Richard Hansen
2e5db5af44 Fix detection of get_ip caller 
This was broken in f6f920eb39.
 2020-07-06 17:14:08 -04:00
Sandro Jäckel
b7e7d27a24
Remove dtdns 2020-07-06 15:59:55 +02:00
Sandro Jäckel
12a4a10c9c
Remove hammernode1 2020-07-06 15:57:52 +02:00
Richard Hansen
323208e9cc Add geturl connectivity unit tests 
Addresses #232
 2020-07-05 18:36:46 -04:00
Sandro
b6770a4d9f
Merge pull request #234 from rhansen/url-parsing 
Fix URL parsing for IPv6 URLs and pathless URLs
 2020-07-06 00:33:22 +02:00
Richard Hansen
06503a483b Fix URL parsing for IPv6 URLs and pathless URLs 
Now the following valid URLs are parsed correctly:
  * http://[::1]:123/foo
  * http://localhost?foo=bar

There are still problems with the URL parsing logic but this is enough
to write some unit tests.
 2020-07-05 18:21:35 -04:00
Richard Hansen
49c8717420 Silence warning when calling geturl from an anonymous sub 2020-07-05 18:16:08 -04:00
Richard Hansen
a15cec7cd9 Stringify default port numbers 
The IO::Socket classes expect strings for the port number because you
can pass service names from `/etc/services`. Numbers work too, but
using strings everywhere makes it easier to write unit tests.
 2020-07-05 16:32:41 -04:00
David Kerr
52fdb0bdeb add missing semicolons and fix incorrect debug message 2020-07-03 17:32:27 -04:00
Sandro
d844039e6c
Merge pull request #175 from rhansen/config-file-parse 
Improve parsing of config file assignments
 2020-07-03 23:24:55 +02:00
Richard Hansen
f7ff1f8259 New options to specify CA certificate location 
This is a prerequisite to adding `geturl()` unit tests (we will need
to run a dummy https server).
 2020-07-03 16:59:18 -04:00
Richard Hansen
6d7d248f79 Improve parsing of config file assignments 
* Ignore empty `key=value` strings in variable assignments. Now the
    following lines are supported with the expected meaning:
      * `a=1 , b=2`
      * `a=1,,b=2`
  * Improve the warning message when there is an unterminated quote.
  * Add a warning if the line ends with a backslash.

Also add unit tests.
 2020-07-03 16:56:01 -04:00
Richard Hansen
283f609b28 Update Vim modeline and Emacs file-local variables 
Both:
  * Force the file type to Perl
  * Set the tab width to 8 so that people cringe in horror at the
    sight of a tab
  * Set the line with to 99

Emacs:
  * Disable indent-tabs-mode
  * Set the indentation level to 4

Vim:
  * Highlight column 100

Addresses #206
 2020-07-01 22:52:29 -04:00
Richard Hansen
8ed93cb576 Move per-service variables to the service definitions 
Most of the entries in `%variables` are only used once. Move them down
to their respective service definitions.

Also:
  * Use idiomatic hash merging instead of `merge()`.
  * Sort the variables by name.
 2020-06-30 22:14:15 -04:00
Richard Hansen
7a2d065a2d Fix woima protocol implementation for loop 2020-06-30 18:41:40 -04:00
Richard Hansen
ccc876c160 Remove the /a regex flag 
This flag was added in Perl 5.14 so we can't use it.
 2020-06-30 18:34:41 -04:00
David Kerr
36d8b511b3 Move un_zero_pad into extract_ipv4, extract_ipv6 
This also causes `is_ipv4` to reject IPv4 addresses with leading
zeros.
 2020-06-30 15:44:24 -04:00
David Kerr
0a999577c7 Simplify the IPv4 regular expression 2020-06-30 15:43:07 -04:00
David Kerr
5da22a8a69 Implement is_ipv6 in terms of extract_ivp6 2020-06-30 15:26:40 -04:00
David Kerr
ab0a4597ce Validate the ip setting 2020-06-30 15:22:13 -04:00
David Kerr
fe513f733d Use is_ipv6, not extract_ipv6, to validate IPv6 address 2020-06-30 15:19:38 -04:00
David Kerr
af1332264f Delete unnecessary address check 
`get_ip` is guaranteed to return a valid IP address or `undef`.
 2020-06-30 15:16:55 -04:00
Richard Hansen
44eaf653f1 Rename *.template to *.in 
Apparently the `.template` extension is commonly used in macOS for a
word processor template file.

See issue #206.
 2020-06-30 13:27:08 -04:00
Renamed from ddclient.template (Browse further)