Commit graph

1426 commits

Author SHA1 Message Date
Sandro
91803cbb41
Merge pull request #237 from rhansen/stringify-ports
Stringify default port numbers
2020-07-05 23:42:26 +02:00
Richard Hansen
a15cec7cd9 Stringify default port numbers
The IO::Socket classes expect strings for the port number because you
can pass service names from `/etc/services`. Numbers work too, but
using strings everywhere makes it easier to write unit tests.
2020-07-05 16:32:41 -04:00
Sandro
d79519f59c
Merge pull request #230 from rhansen/autoconf-test-find
Require `find` to be installed
2020-07-03 23:46:49 +02:00
Richard Hansen
9b1fc13d40 Require find to be installed 2020-07-03 17:35:11 -04:00
Richard Hansen
f527b7487c
Merge pull request #228 from dkerr64/cleanup
Add missing semicolons and fix incorrect debug message
2020-07-03 17:34:30 -04:00
David Kerr
52fdb0bdeb add missing semicolons and fix incorrect debug message 2020-07-03 17:32:27 -04:00
Sandro
d844039e6c
Merge pull request #175 from rhansen/config-file-parse
Improve parsing of config file assignments
2020-07-03 23:24:55 +02:00
Sandro
55b3754838
Merge pull request #227 from rhansen/ca-certs
New options to specify CA certificate location
2020-07-03 23:20:35 +02:00
Richard Hansen
f7ff1f8259 New options to specify CA certificate location
This is a prerequisite to adding `geturl()` unit tests (we will need
to run a dummy https server).
2020-07-03 16:59:18 -04:00
Richard Hansen
6d7d248f79 Improve parsing of config file assignments
* Ignore empty `key=value` strings in variable assignments. Now the
    following lines are supported with the expected meaning:
      * `a=1 , b=2`
      * `a=1,,b=2`
  * Improve the warning message when there is an unterminated quote.
  * Add a warning if the line ends with a backslash.

Also add unit tests.
2020-07-03 16:56:01 -04:00
Sandro
391a513d5c
Merge pull request #223 from rhansen/dist-tarball 2020-07-03 20:51:09 +02:00
Richard Hansen
b9b594fcea Test that the distribution tarball is complete 2020-07-03 14:27:18 -04:00
Sandro
f0eb0850da
Merge pull request #224 from rhansen/fedora-find
Install findutils on Fedora
2020-07-03 08:35:08 +02:00
Sandro
8cff1a6da2
Merge pull request #222 from rhansen/ci-debian
Also run tests on Debian testing, stable, oldstable
2020-07-03 08:33:40 +02:00
Richard Hansen
451bdd1086 Also run tests on Debian testing, stable, oldstable 2020-07-02 14:05:18 -04:00
Richard Hansen
a00d2cc18e Install findutils on Fedora 2020-07-02 09:58:58 -04:00
Sandro
9c6c7a2b39
Merge pull request #219 from rhansen/editor-variables
Update Vim modeline and Emacs file-local variables
2020-07-02 09:46:09 +02:00
Richard Hansen
283f609b28 Update Vim modeline and Emacs file-local variables
Both:
  * Force the file type to Perl
  * Set the tab width to 8 so that people cringe in horror at the
    sight of a tab
  * Set the line with to 99

Emacs:
  * Disable indent-tabs-mode
  * Set the indentation level to 4

Vim:
  * Highlight column 100

Addresses #206
2020-07-01 22:52:29 -04:00
Richard Hansen
5507b76d83
Merge pull request #218 from ddclient/redhat
Add redhat to ci
2020-07-01 21:50:51 -04:00
Sandro Jäckel
a23b8d558b Add redhat to ci 2020-07-01 21:48:03 -04:00
Richard Hansen
1614e62f2d
Merge pull request #221 from thorsteneb/master
Add FreeBSD; change README to use json-pp for Ubuntu
2020-07-01 12:34:41 -04:00
Thorsten Behrens
2afdf5043c Add FreeBSD; change README to use json-pp for Ubuntu 2020-07-01 12:33:21 -04:00
Richard Hansen
22e9da2d79
Merge pull request #220 from rhansen/dco
Document that contributions are subject to the DCO
2020-07-01 11:47:43 -04:00
Richard Hansen
290077dc5e Document that contributions are subject to the DCO 2020-07-01 11:46:32 -04:00
Richard Hansen
23e372d283
Merge pull request #216 from ddclient/perl-version
Explicit require version
2020-07-01 11:44:23 -04:00
Sandro Jäckel
c4f2670d8b Explicit require version
because centos does not include it at all times
2020-07-01 11:43:47 -04:00
Sandro
19813a7247
Merge pull request #195 from rhansen/config
Move per-service variables to the service definitions
2020-07-01 10:07:46 +02:00
Richard Hansen
8ed93cb576 Move per-service variables to the service definitions
Most of the entries in `%variables` are only used once. Move them down
to their respective service definitions.

Also:
  * Use idiomatic hash merging instead of `merge()`.
  * Sort the variables by name.
2020-06-30 22:14:15 -04:00
Sandro
ef566064d5
Merge pull request #215 from rhansen/verbose-tests
Recommend `VERBOSE=1` when running tests
2020-07-01 01:42:51 +02:00
Richard Hansen
c198e21c16 Recommend VERBOSE=1 when running tests
This causes Automake to output a failed test's log so that you don't
have to look at the `.log` file yourself.
2020-06-30 19:37:01 -04:00
Richard Hansen
296576d57f
Merge pull request #209 from ddclient/ci-centos
Add test for centos, use matrix for ubuntu
2020-06-30 18:57:39 -04:00
Sandro Jäckel
af718224b3 Add fedora to ci 2020-06-30 18:54:19 -04:00
Sandro Jäckel
ea840db62d Add centos 6 to ci 2020-06-30 18:51:41 -04:00
Sandro Jäckel
c4fae81053 Add centos 8 to ci 2020-06-30 18:51:41 -04:00
Richard Hansen
38d71b2efa Set VERBOSE=1 to show logs on failure 2020-06-30 18:47:22 -04:00
Sandro Jäckel
0ca6e62b67 Use matrix for ubuntu 2020-06-30 18:47:22 -04:00
Sandro
504e326274
Merge pull request #214 from rhansen/woima
Fix woima protocol implementation `for` loop
2020-07-01 00:45:31 +02:00
Richard Hansen
7a2d065a2d Fix woima protocol implementation for loop 2020-06-30 18:41:40 -04:00
Sandro
43c0581334
Merge pull request #213 from rhansen/regex-flag-compat
Remove the `/a` regex flag
2020-07-01 00:37:13 +02:00
Richard Hansen
ccc876c160 Remove the /a regex flag
This flag was added in Perl 5.14 so we can't use it.
2020-06-30 18:34:41 -04:00
Sandro
05e5759aa1
Merge pull request #212 from rhansen/automake-parallel-tests
Enable Automake's parallel-tests feature
2020-07-01 00:27:17 +02:00
Richard Hansen
65bc4cd986 Enable Automake's parallel-tests feature
Apparently it's off by default in Automake 1.11.
2020-06-30 18:22:22 -04:00
Richard Hansen
034e6501ed
Merge pull request #196 from dkerr64/Cleanup-extract_ipv4-and-is_ipv6-and-usage
Cleanup extract ipv4 and is ipv6 and usage
2020-06-30 15:54:25 -04:00
David Kerr
36d8b511b3 Move un_zero_pad into extract_ipv4, extract_ipv6
This also causes `is_ipv4` to reject IPv4 addresses with leading
zeros.
2020-06-30 15:44:24 -04:00
David Kerr
0a999577c7 Simplify the IPv4 regular expression 2020-06-30 15:43:07 -04:00
David Kerr
5da22a8a69 Implement is_ipv6 in terms of extract_ivp6 2020-06-30 15:26:40 -04:00
David Kerr
ab0a4597ce Validate the ip setting 2020-06-30 15:22:13 -04:00
David Kerr
fe513f733d Use is_ipv6, not extract_ipv6, to validate IPv6 address 2020-06-30 15:19:38 -04:00
David Kerr
af1332264f Delete unnecessary address check
`get_ip` is guaranteed to return a valid IP address or `undef`.
2020-06-30 15:16:55 -04:00
Sandro
7e0f696c87
Merge pull request #210 from rhansen/tap-driver.sh
Tell Git to ignore changes to build-aux/tap-driver.sh
2020-06-30 21:00:36 +02:00