Fabio/ddclient
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Don't abort if unable to write the cache file

Browse source
This commit is contained in:
Richard Hansen 2020-07-06 19:39:29 -04:00
parent 6ae5fe62d7
commit ee8e1e8844
2 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
ddclient.in
View file

@ -1011,8 +1011,9 @@ sub write_cache {
$saved_cache = undef; $saved_cache = undef;
local *FD; local *FD;
if (!open(FD, "> $file")) { if (!open(FD, ">", $file)) {
fatal("Cannot create file '%s'. (%s)", $file, $!); warning("Failed to create cache file %s: %s", $file, $!);
return;
} }
printf FD "## %s-%s\n", $program, $version; printf FD "## %s-%s\n", $program, $version;
printf FD "## last updated at %s (%d)\n", prettytime($now), $now; printf FD "## last updated at %s (%d)\n", prettytime($now), $now;

5
t/write_cache.pl
View file

@ -15,6 +15,10 @@ $module->redefine('warning', sub {
my $tmpdir = File::Temp->newdir(); my $tmpdir = File::Temp->newdir();
my $dir = $tmpdir->dirname(); my $dir = $tmpdir->dirname();
diag("temporary directory: $dir"); diag("temporary directory: $dir");
my $ro_tmpdir = File::Temp->newdir();
my $ro_dir = $ro_tmpdir->dirname();
chmod(0500, $ro_dir) or BAIL_OUT($!);
diag("temporary read-only directory: $ro_dir");
sub tc { sub tc {
return { return {
@ -28,6 +32,7 @@ my @test_cases = (
tc("create cache file", catfile($dir, 'a', 'b', 'cachefile'), undef), tc("create cache file", catfile($dir, 'a', 'b', 'cachefile'), undef),
tc("overwrite cache file", catfile($dir, 'a', 'b', 'cachefile'), undef), tc("overwrite cache file", catfile($dir, 'a', 'b', 'cachefile'), undef),
tc("bad directory", catfile($dir, 'a', 'b', 'cachefile', 'bad'), qr/File exists/), tc("bad directory", catfile($dir, 'a', 'b', 'cachefile', 'bad'), qr/File exists/),
tc("read-only directory", catfile($ro_dir, 'cachefile'), qr/Permission denied/),
); );
for my $tc (@test_cases) { for my $tc (@test_cases) {