Fabio/ddclient
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

So the bug was actually in the escape_curl_param function, not that the data should not be escaped

Browse source
This commit is contained in:
David Kerr 2020-08-22 21:32:27 -04:00
parent 6ae64e6cfb
commit d1d7548e09
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
ddclient.in
View file

@ -2283,8 +2283,8 @@ sub escape_curl_param {
my $str = shift // '';
return '' if ($str eq '');
$str =~ s/"/\\"/g; ## Escape double-quotes
$str =~ s/\\/\\\\/g;## Escape backslashes
$str =~ s/"/\\"/g; ## Escape double-quotes
$str =~ s/\n/\\n/g; ## Escape newline
$str =~ s/\r/\\r/g; ## Escape carrage return
$str =~ s/\t/\\t/g; ## Escape tabs
@ -2412,7 +2412,7 @@ sub fetch_via_curl {
push(@curlopt, @header_lines);
# Add in the data if any was provided (for POST/PATCH)
push(@curlopt, "data=${data}") if ($data);
push(@curlopt, "data=\"".escape_curl_param(${data}).'"') if ($data);
# don't include ${url} as that might expose login credentials
$0 = sprintf("%s - Curl system cmd sending to %s", $program, "${protocol}://${server}");