From c4ff6c12bd7dc1f9a0a3def6f60ba0c89222f32b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20Josef=20=C5=A0pa=C4=8Dek?= Date: Thu, 8 Dec 2022 14:04:33 +0100 Subject: [PATCH] Remove setting of MultiHomed, which is default in IO::Socket::IP From doc in IO::Socket::IP in "IO::Socket::INET" INCOMPATIBILITES section: ----- The behaviour enabled by "MultiHomed" is in fact implemented by "IO::Socket::IP" as it is required to correctly support searching for a useable address from the results of the getaddrinfo(3) call. The constructor will ignore the value of this argument, except if it is defined but false. An exception is thrown in this case, because that would request it disable the getaddrinfo(3) search behaviour in the first place. ----- --- ddclient.in | 1 - t/geturl_ssl.pl | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/ddclient.in b/ddclient.in index f0b0f3a..e0c3a16 100755 --- a/ddclient.in +++ b/ddclient.in @@ -2480,7 +2480,6 @@ sub fetch_via_socket_io { PeerAddr => $peer, PeerPort => $port, Proto => 'tcp', - MultiHomed => 1, Timeout => opt('timeout'), ); my $socket_class = 'IO::Socket::IP'; diff --git a/t/geturl_ssl.pl b/t/geturl_ssl.pl index c070def..2b45f0b 100644 --- a/t/geturl_ssl.pl +++ b/t/geturl_ssl.pl @@ -44,7 +44,7 @@ my $args; # * opt_ssl: Value to return from opt('ssl'). Defaults to 0. # * opt_ssl_ca_dir: Value to return from opt('ssl_ca_dir'). Defaults to undef. # * opt_ssl_ca_file: Value to return from opt('ssl_ca_file'). Defaults to undef. -# * want_args: Args that should be passed to the socket constructor minus MultiHomed, Proto, +# * want_args: Args that should be passed to the socket constructor minus Proto, # Timeout, and original_socket_class. # * want_req_method: The HTTP method geturl is expected to use. Defaults to 'GET'. # * want_req_uri: URI that geturl is expected to request. @@ -244,7 +244,6 @@ for my $tc (@test_cases) { local $TODO = $tc->{todo}; subtest $tc->{name} => sub { my %want_args = ( - MultiHomed => 1, Proto => 'tcp', Timeout => ddclient::opt('timeout'), original_socket_class => 'IO::Socket::SSL',