Fabio/ddclient
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

tests: dnsexit2: Declare @requests where used

Browse source 
for readability
This commit is contained in:
Richard Hansen 2024-09-06 00:37:34 -04:00
parent d7861b6d61
commit bd1e42ac6c
1 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
t/protocol_dnsexit2.pl
View file

@ -7,7 +7,6 @@ eval { require LWP::UserAgent; } or plan(skip_all => $@);
ddclient::load_json_support('dnsexit2'); ddclient::load_json_support('dnsexit2');
my @requests; # Declare global variable to store requests, used for tests.
my @httpd_requests; # Declare variable specificly used for the httpd process (which cannot be shared with tests). my @httpd_requests; # Declare variable specificly used for the httpd process (which cannot be shared with tests).
my $httpd = ddclient::Test::Fake::HTTPD->new(); my $httpd = ddclient::Test::Fake::HTTPD->new();
@ -56,7 +55,6 @@ sub decode_and_sort_array {
sub reset_test_data { sub reset_test_data {
my $response = $ua->get($httpd->endpoint . '/reset_requests'); my $response = $ua->get($httpd->endpoint . '/reset_requests');
die "Failed to reset requests" unless $response->is_success; die "Failed to reset requests" unless $response->is_success;
@requests = ();
} }
sub get_requests { sub get_requests {
@ -80,7 +78,7 @@ subtest 'Testing nic_dnsexit2_update' => sub {
'ttl' => 5 'ttl' => 5
}); });
test_nic_dnsexit2_update(\%config, 'host.my.zone.com'); test_nic_dnsexit2_update(\%config, 'host.my.zone.com');
@requests = get_requests(); my @requests = get_requests();
is($requests[0]->{method}, 'POST', 'Method is correct'); is($requests[0]->{method}, 'POST', 'Method is correct');
is($requests[0]->{uri}, '/update', 'URI contains correct path'); is($requests[0]->{uri}, '/update', 'URI contains correct path');
like($requests[0]->{headers}, qr/Content-Type: application\/json/, 'Content-Type header is correct'); like($requests[0]->{headers}, qr/Content-Type: application\/json/, 'Content-Type header is correct');
@ -120,7 +118,7 @@ subtest 'Testing nic_dnsexit2_update without a zone set' => sub {
'ttl' => 10 'ttl' => 10
}); });
test_nic_dnsexit2_update(\%config, 'myhost.zone.com'); test_nic_dnsexit2_update(\%config, 'myhost.zone.com');
@requests = get_requests(); my @requests = get_requests();
my $data = decode_and_sort_array($requests[0]->{content}); my $data = decode_and_sort_array($requests[0]->{content});
my $expected_data = decode_and_sort_array({ my $expected_data = decode_and_sort_array({
'domain' => 'myhost.zone.com', 'domain' => 'myhost.zone.com',
@ -185,7 +183,7 @@ subtest 'Testing nic_dnsexit2_update with two hostnames, one with a zone and one
} }
] ]
}); });
@requests = get_requests(); my @requests = get_requests();
for my $i (0..1) { for my $i (0..1) {
my $data = decode_and_sort_array($requests[$i]->{content}); my $data = decode_and_sort_array($requests[$i]->{content});
is_deeply($data, $expected_data1, 'Data is correct for call host1') if $i == 0; is_deeply($data, $expected_data1, 'Data is correct for call host1') if $i == 0;