Fabio/ddclient
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove defaults from required variables without sensible defaults

Browse source 
Required variables with defaults don't make sense; remove the default
values on variables that don't have sensible defaults, such as login
and password.
This commit is contained in:
Richard Hansen 2024-06-28 02:33:33 -04:00
parent be9e305e73
commit b8a0a26441
1 changed files with 12 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
ddclient.in
View file

@ -587,8 +587,8 @@ my %variables = (
'fwv4-skip' => setv(T_STRING,0, 0, undef, undef), 'fwv4-skip' => setv(T_STRING,0, 0, undef, undef),
'fwv6' => setv(T_ANY, 0, 0, '', undef), 'fwv6' => setv(T_ANY, 0, 0, '', undef),
'fwv6-skip' => setv(T_STRING,0, 0, undef, undef), 'fwv6-skip' => setv(T_STRING,0, 0, undef, undef),
'fw-login' => setv(T_LOGIN, 1, 0, '', undef), 'fw-login' => setv(T_LOGIN, 1, 0, undef, undef),
'fw-password' => setv(T_PASSWD,1, 0, '', undef), 'fw-password' => setv(T_PASSWD,1, 0, undef, undef),
'cmd' => setv(T_PROG, 0, 0, '', undef), 'cmd' => setv(T_PROG, 0, 0, '', undef),
'cmd-skip' => setv(T_STRING,0, 0, undef, undef), 'cmd-skip' => setv(T_STRING,0, 0, undef, undef),
'cmdv4' => setv(T_PROG, 0, 0, '', undef), 'cmdv4' => setv(T_PROG, 0, 0, '', undef),
@ -620,9 +620,9 @@ my %variables = (
}, },
'protocol-common-defaults' => { 'protocol-common-defaults' => {
'server' => setv(T_FQDNP, 1, 0, 'members.dyndns.org', undef), 'server' => setv(T_FQDNP, 1, 0, 'members.dyndns.org', undef),
'login' => setv(T_LOGIN, 1, 0, '', undef), 'login' => setv(T_LOGIN, 1, 0, undef, undef),
'password' => setv(T_PASSWD,1, 0, '', undef), 'password' => setv(T_PASSWD,1, 0, undef, undef),
'host' => setv(T_STRING,1, 1, '', undef), 'host' => setv(T_STRING,1, 1, undef, undef),
'use' => setv(T_USE, 0, 0, 'ip', undef), 'use' => setv(T_USE, 0, 0, 'ip', undef),
'usev4' => setv(T_USEV4, 0, 0, 'disabled', undef), 'usev4' => setv(T_USEV4, 0, 0, 'disabled', undef),
@ -741,7 +741,7 @@ my %protocols = (
'static' => setv(T_BOOL, 0, 1, 0, undef), 'static' => setv(T_BOOL, 0, 1, 0, undef),
'ttl' => setv(T_NUMBER, 1, 0, 1, undef), 'ttl' => setv(T_NUMBER, 1, 0, 1, undef),
'wildcard' => setv(T_BOOL, 0, 1, 0, undef), 'wildcard' => setv(T_BOOL, 0, 1, 0, undef),
'zone' => setv(T_FQDN, 1, 0, '', undef), 'zone' => setv(T_FQDN, 1, 0, undef, undef),
}, },
}, },
'cloudns' => { 'cloudns' => {
@ -763,7 +763,7 @@ my %protocols = (
%{$variables{'protocol-common-defaults'}}, %{$variables{'protocol-common-defaults'}},
'login' => undef, 'login' => undef,
'server' => setv(T_FQDNP, 1, 0, 'api.digitalocean.com', undef), 'server' => setv(T_FQDNP, 1, 0, 'api.digitalocean.com', undef),
'zone' => setv(T_FQDN, 1, 0, '', undef), 'zone' => setv(T_FQDN, 1, 0, undef, undef),
}, },
}, },
'dinahosting' => { 'dinahosting' => {
@ -902,7 +902,7 @@ my %protocols = (
'min-interval' => setv(T_DELAY, 0, 0, interval('5m'), 0), 'min-interval' => setv(T_DELAY, 0, 0, interval('5m'), 0),
'server' => setv(T_FQDNP, 1, 0, 'api.godaddy.com/v1/domains', undef), 'server' => setv(T_FQDNP, 1, 0, 'api.godaddy.com/v1/domains', undef),
'ttl' => setv(T_NUMBER, 1, 0, 600, undef), 'ttl' => setv(T_NUMBER, 1, 0, 600, undef),
'zone' => setv(T_FQDN, 1, 0, '', undef), 'zone' => setv(T_FQDN, 1, 0, undef, undef),
}, },
}, },
'googledomains' => { 'googledomains' => {
@ -925,7 +925,7 @@ my %protocols = (
'min-interval' => setv(T_DELAY, 0, 0, interval('1m'), 0), 'min-interval' => setv(T_DELAY, 0, 0, interval('1m'), 0),
'server' => setv(T_FQDNP, 1, 0, 'dns.hetzner.com/api/v1', undef), 'server' => setv(T_FQDNP, 1, 0, 'dns.hetzner.com/api/v1', undef),
'ttl' => setv(T_NUMBER, 0, 0, 60, 60), 'ttl' => setv(T_NUMBER, 0, 0, 60, 60),
'zone' => setv(T_FQDN, 1, 0, '', undef), 'zone' => setv(T_FQDN, 1, 0, undef, undef),
}, },
}, },
'mythicdyn' => { 'mythicdyn' => {
@ -991,7 +991,7 @@ my %protocols = (
'login' => setv(T_LOGIN, 1, 0, '/usr/bin/nsupdate', undef), 'login' => setv(T_LOGIN, 1, 0, '/usr/bin/nsupdate', undef),
'tcp' => setv(T_BOOL, 0, 1, 0, undef), 'tcp' => setv(T_BOOL, 0, 1, 0, undef),
'ttl' => setv(T_NUMBER, 0, 1, 600, undef), 'ttl' => setv(T_NUMBER, 0, 1, 600, undef),
'zone' => setv(T_STRING, 1, 1, '', undef), 'zone' => setv(T_STRING, 1, 1, undef, undef),
}, },
}, },
'ovh' => { 'ovh' => {
@ -1012,8 +1012,8 @@ my %protocols = (
%{$variables{'protocol-common-defaults'}}, %{$variables{'protocol-common-defaults'}},
'login' => undef, 'login' => undef,
'password' => undef, 'password' => undef,
'apikey' => setv(T_PASSWD, 1, 0, '', undef), 'apikey' => setv(T_PASSWD, 1, 0, undef, undef),
'secretapikey' => setv(T_PASSWD, 1, 0, '', undef), 'secretapikey' => setv(T_PASSWD, 1, 0, undef, undef),
'root-domain' => setv(T_OFQDN, 0, 0, '', undef), 'root-domain' => setv(T_OFQDN, 0, 0, '', undef),
'on-root-domain' => setv(T_BOOL, 0, 0, 0, undef), 'on-root-domain' => setv(T_BOOL, 0, 0, 0, undef),
}, },