From b4a2bbf368a4d57f38966f701edba8bff5c0328c Mon Sep 17 00:00:00 2001
From: Dimitris Paraskevopoulos <dpparaskevopoulos@gmail.com>
Date: Thu, 22 Sep 2022 15:46:29 +0300
Subject: [PATCH] Formatting changes from review comments.

---
 ddclient.in | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/ddclient.in b/ddclient.in
index d84d0d8..6c85170 100755
--- a/ddclient.in
+++ b/ddclient.in
@@ -5098,19 +5098,15 @@ sub nic_njalla_update {
         my $ip_output = '';
 
         # Build url
-        my $url = "https://$config{$h}{'server'}/update/";
-        $url .= "?h=";
-        $url .= $h;
-        $url .= "&k=";
-        $url .= $config{$h}{'password'};
+        my $url = "https://$config{$h}{'server'}/update/?h=$h&k=$config{$h}{'password'}";
         my $auto = 1;
         foreach my $ip ($ipv4, $ipv6) {
             next if (!$ip);
             $auto = 0;
             my $ipv  = ($ip eq ($ipv6 // '')) ? '6' : '4';
             my $type = ($ip eq ($ipv6 // '')) ? 'aaaa' : 'a';
-            $ip_output .= ' IP v' . $ipv . ': '. $ip .',';
-            $url .= '&' . $type . '=' . $ip;
+            $ip_output .= " IP v$ipv: $ip,";
+            $url .= "&$type=$ip";
         }
         $url .= (($auto eq 1)) ? '&auto' : '';
         $url .= (($quietreply eq 1)) ? '&quiet' : '';