From 71acd749a17ecaa7e67c7de8c2f4d55667244042 Mon Sep 17 00:00:00 2001
From: Richard Hansen <rhansen@rhansen.org>
Date: Mon, 6 Jul 2020 23:48:33 -0400
Subject: [PATCH] Simplify `parse_assignments`

---
 ddclient.in | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/ddclient.in b/ddclient.in
index c2a25da..28efd52 100755
--- a/ddclient.in
+++ b/ddclient.in
@@ -1045,17 +1045,13 @@ sub parse_assignments {
     while (1) {
         (my $name, my $value, $rest) = parse_assignment($rest);
         $rest =~ s/^[,\s]+//;
-        if (defined $name) {
-            if ($name eq 'fw-banlocal') {
-                warning("'fw-banlocal' is deprecated and does nothing");
-                next;
-            }
-            $variables{$name} = $value;
-        } else {
-            last;
+        return ($rest, %variables) if !defined($name);
+        if ($name eq 'fw-banlocal') {
+            warning("'fw-banlocal' is deprecated and does nothing");
+            next;
         }
+        $variables{$name} = $value;
     }
-    return ($rest, %variables);
 }
 sub parse_assignment {
     my ($rest) = @_;