Fabio/ddclient
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Do not use quotemeta on cmdv4 and cmdv6 arguments

Browse source 
`quotemeta` prevents executing commands with arguments.  With this
change, it is now possible to get an IP address with:

    usev4=cmdv4
    cmdv4="dig +short myip.opendns.com @resolver1.opendns.com"
This commit is contained in:
steven 2024-11-26 17:35:23 +00:00 committed by Richard Hansen
parent 17fc4c0a35
commit ae01ba26c1
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
ddclient.in
View file

@ -3343,8 +3343,7 @@ sub get_ipv4 {
warning("'--cmd-skip' ignored for '--usev4=$p{'usev4'}'") warning("'--cmd-skip' ignored for '--usev4=$p{'usev4'}'")
if opt('verbose') && defined($p{'cmd-skip'}); if opt('verbose') && defined($p{'cmd-skip'});
if ($arg) { if ($arg) {
my $sys_cmd = quotemeta($arg); $reply = qx{$arg};
$reply = qx{$sys_cmd};
$reply = '' if $?; $reply = '' if $?;
} }
} elsif ($p{'usev4'} eq 'webv4') { } elsif ($p{'usev4'} eq 'webv4') {
@ -3457,8 +3456,7 @@ sub get_ipv6 {
warning("'--cmd-skip' ignored for '--usev6=$p{'usev6'}'") warning("'--cmd-skip' ignored for '--usev6=$p{'usev6'}'")
if opt('verbose') && defined($p{'cmd-skip'}); if opt('verbose') && defined($p{'cmd-skip'});
if ($arg) { if ($arg) {
my $sys_cmd = quotemeta($arg); $reply = qx{$arg};
$reply = qx{$sys_cmd};
$reply = '' if $?; $reply = '' if $?;
} }
} elsif ($p{'usev6'} eq 'webv6' || $p{'usev6'} eq 'web') { } elsif ($p{'usev6'} eq 'webv6' || $p{'usev6'} eq 'web') {