Fabio/ddclient
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

tests: Fix ssl option for dnsexit2 protocol tests

Browse source 
The `ssl` option is a global option, not a per-host option.  This
commit could instead do:

    local $ddclient::globals{ssl} = 0;

but it's more straightforward to include `http://` in the `server`
option, and it tests that `server` supports the inclusion of the
scheme.
This commit is contained in:
Richard Hansen 2024-08-18 00:26:49 -04:00
parent 598dee50ca
commit a136ba4cdc
1 changed files with 4 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
t/protocol_dnsexit2.pl
View file

@ -66,7 +66,6 @@ sub get_requests {
subtest 'Testing nic_dnsexit2_update' => sub { subtest 'Testing nic_dnsexit2_update' => sub {
my %config = ( my %config = (
'host.my.zone.com' => { 'host.my.zone.com' => {
'ssl' => 'no',
'verbose' => 'yes', 'verbose' => 'yes',
'usev4' => 'ipv4', 'usev4' => 'ipv4',
'wantipv4' => '8.8.4.4', 'wantipv4' => '8.8.4.4',
@ -75,7 +74,7 @@ subtest 'Testing nic_dnsexit2_update' => sub {
'protocol' => 'dnsexit2', 'protocol' => 'dnsexit2',
'password' => 'mytestingpassword', 'password' => 'mytestingpassword',
'zone' => 'my.zone.com', 'zone' => 'my.zone.com',
'server' => $httpd->host_port(), 'server' => $httpd->endpoint(),
'path' => '/update', 'path' => '/update',
'ttl' => 5 'ttl' => 5
}); });
@ -111,13 +110,12 @@ subtest 'Testing nic_dnsexit2_update' => sub {
subtest 'Testing nic_dnsexit2_update without a zone set' => sub { subtest 'Testing nic_dnsexit2_update without a zone set' => sub {
my %config = ( my %config = (
'myhost.zone.com' => { 'myhost.zone.com' => {
'ssl' => 'yes',
'verbose' => 'yes', 'verbose' => 'yes',
'usev4' => 'ipv4', 'usev4' => 'ipv4',
'wantipv4' => '8.8.4.4', 'wantipv4' => '8.8.4.4',
'protocol' => 'dnsexit2', 'protocol' => 'dnsexit2',
'password' => 'anotherpassword', 'password' => 'anotherpassword',
'server' => $httpd->host_port(), 'server' => $httpd->endpoint(),
'path' => '/update-alt', 'path' => '/update-alt',
'ttl' => 10 'ttl' => 10
}); });
@ -143,24 +141,22 @@ subtest 'Testing nic_dnsexit2_update without a zone set' => sub {
subtest 'Testing nic_dnsexit2_update with two hostnames, one with a zone and one without' => sub { subtest 'Testing nic_dnsexit2_update with two hostnames, one with a zone and one without' => sub {
my %config = ( my %config = (
'host1.zone.com' => { 'host1.zone.com' => {
'ssl' => 'yes',
'verbose' => 'yes', 'verbose' => 'yes',
'usev4' => 'ipv4', 'usev4' => 'ipv4',
'wantipv4' => '8.8.4.4', 'wantipv4' => '8.8.4.4',
'protocol' => 'dnsexit2', 'protocol' => 'dnsexit2',
'password' => 'testingpassword', 'password' => 'testingpassword',
'server' => $httpd->host_port(), 'server' => $httpd->endpoint(),
'path' => '/update', 'path' => '/update',
'ttl' => 5 'ttl' => 5
}, },
'host2.zone.com' => { 'host2.zone.com' => {
'ssl' => 'yes',
'verbose' => 'yes', 'verbose' => 'yes',
'usev6' => 'ipv6', 'usev6' => 'ipv6',
'wantipv6' => '2001:4860:4860::8888', 'wantipv6' => '2001:4860:4860::8888',
'protocol' => 'dnsexit2', 'protocol' => 'dnsexit2',
'password' => 'testingpassword', 'password' => 'testingpassword',
'server' => $httpd->host_port(), 'server' => $httpd->endpoint(),
'path' => '/update', 'path' => '/update',
'ttl' => 10, 'ttl' => 10,
'zone' => 'zone.com' 'zone' => 'zone.com'