Fabio/ddclient
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

group_hosts_by improvements

Browse source 
* Don't modify `$config{$h}{$v}` if variable `$v` for host `$h` is
    `undef`.
  * Tolerate the user passing `wantip` or duplicate keys.
This commit is contained in:
Richard Hansen 2020-06-29 00:52:08 -04:00
parent b1da99c361
commit 8fcc9b0e2f
1 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
ddclient
View file

@ -2355,13 +2355,11 @@ sub extract_ipv6 {
######################################################################
sub group_hosts_by {
my ($hosts, $attributes) = @_;
my %attrs = (map({ ($_ => 1) } @$attributes), 'wantip' => 1);
my @attrs = sort(keys(%attrs));
my %groups = ();
foreach my $h (@$hosts) {
my @keys = (@$attributes, 'wantip');
map { $config{$h}{$_} = '' unless exists $config{$h}{$_} } @keys;
my $sig = join(',', map { "$_=$config{$h}{$_}" } @keys);
my $sig = join(',', map({ sprintf("%s=%s", $_, $config{$h}{$_} // '') } @attrs));
push @{$groups{$sig}}, $h;
}
return %groups;