Fabio/ddclient
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

easydns: Delete incorrect handling of TOOSOON error

Browse source 
Before:
  * `$scale` was ignored causing it to set `wtime` to 5s in the
    future, which is too brief.  Fortunately, `min-error-interval`
    applied which prevented overly aggressive retries.
  * The lack of call to `failed` meant that `$result` was not set to
    "FAILED" and thus `mail-failure` recipients were not emailed.

Now `TOOSOON` is treated like any other error and will result in a
retry after `min-error-interval` (default: 5m).
This commit is contained in:
Richard Hansen 2024-07-19 19:26:08 -04:00
parent fb990208b3
commit 7a4b96e04e
1 changed files with 0 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
ddclient.in
View file

@ -4833,15 +4833,6 @@ sub nic_easydns_update {
$config{$h}{'mtime'} = $now; $config{$h}{'mtime'} = $now;
success("$h: IPv4 address set to $ipv4") if $ipv4; success("$h: IPv4 address set to $ipv4") if $ipv4;
success("$h: IPv6 address set to $ipv6") if $ipv6; success("$h: IPv6 address set to $ipv6") if $ipv6;
} elsif ($status =~ /TOOSOON/) {
## make sure we wait at least a little
my ($wait, $units) = (5, 'm');
my ($sec, $scale) = ($wait, 1);
($scale, $units) = (1, 'seconds') if $units eq 's';
($scale, $units) = (60, 'minutes') if $units eq 'm';
($scale, $units) = (60*60, 'hours') if $units eq 'h';
$config{$h}{'wtime'} = $now + $sec;
warning("$h: $status: wait $wait $units before further updates");
} elsif (exists $errors{$status}) { } elsif (exists $errors{$status}) {
failed("$h: $status: $errors{$status}"); failed("$h: $status: $errors{$status}");
} else { } else {