Fabio/ddclient
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

write_recap: Remove unnecessary recap existence check

Browse source
This commit is contained in:
Richard Hansen 2024-08-26 03:18:07 -04:00
parent 2927f205ea
commit 7660ca52bf
1 changed files with 1 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
ddclient.in
View file

@ -1567,19 +1567,7 @@ sub write_recap {
# represent `undef` in the cache file and to simplify testing. Also, entries for non-recap
# variables (which can happen after changing a host's protocol or after switching to a
# different version of ddclient) are deleted.
#
# TODO: The "configuration change detection" variables are also syncronized if `$recap{$h}`
# doesn't exist. Why is this done? Perhaps the intention was to prevent the
# force-if-config-changed logic from triggering the very first cycle (when there is no
# previous update attempt). However:
# * There's a bug: This function isn't called until after `update_nics` has already
# checked the force-if-config-changed condition, so syncing the values here is too late
# to suppress the first cycle's force-if-config-changed logic.
# * It's unnecessary: If there have not been any update attempts, an update attempt
# should be made anyway, and already is. (`update_nics` already forces an update if
# `$recap{$h}` doesn't exist, and that check is done before the force-if-config-changed
# check.)
if (!exists $recap{$h} || $config{$h}{'update'}) {
if ($config{$h}{'update'}) {
delete($config{$h}{'update'});
$recap{$h} = {};
for my $v (keys(%$vars)) {