From 5e7609ea2a5e0c59fb7c64cd210731a665fceb8d Mon Sep 17 00:00:00 2001
From: Lenard Hess <lenard@rrhess.de>
Date: Sat, 3 Feb 2024 13:57:09 +0100
Subject: [PATCH] porkbun: Added 'root-domain' config option

Porkbun API requires separation of the root domain and subdomains.
Previously ddclient only supported one layer of subdomain or the root domain
by selecting between the two with the boolean 'on-root-domain'.

This change now allows to specify the root domain via the 'root-domain' parameter
ddclient will then split the host domain into root and subdomain
---
 ddclient.in | 28 +++++++++++++++++++++++-----
 1 file changed, 23 insertions(+), 5 deletions(-)

diff --git a/ddclient.in b/ddclient.in
index 5c50d3d..dfe6a7d 100755
--- a/ddclient.in
+++ b/ddclient.in
@@ -869,6 +869,7 @@ my %services = (
         'variables'  => {
             'apikey'         => setv(T_PASSWD, 1, 0, '',         undef),
             'secretapikey'   => setv(T_PASSWD, 1, 0, '',         undef),
+            'root-domain'    => setv(T_OFQDN,  0, 0, '',         undef),
             'on-root-domain' => setv(T_BOOL,   0, 0, 0,          undef),
             'login'          => setv(T_LOGIN,  0, 0, 'unused',   undef),
             'password'       => setv(T_PASSWD, 0, 0, 'unused',   undef),
@@ -7114,6 +7115,7 @@ https://kb.porkbun.com/article/190-getting-started-with-the-porkbun-api
 Available configuration variables:
   * apikey (required): API Key of Porkbun API
   * secretapikey (required): Secret API Key of Porkbun API
+  * root-domain: The root domain of the specified domain name.
   * on-root-domain=yes or no (default: no): Indicates whether the specified domain name (FQDN) is
     an unnamed record (Zone APEX) in a zone.
     It is useful to specify it as a local variable as shown in the example.
@@ -7168,12 +7170,28 @@ sub nic_porkbun_update {
             my $rrset_type = is_ipv6($ip) ? "AAAA" : "A";
 
             my ($sub_domain, $domain);
-            if ($config{$host}{'on-root-domain'}) {
-                $sub_domain = '';
-                $domain = $host;
-            } else {
-                ($sub_domain, $domain) = split(/\./, $host, 2);
+            if ($config{$host}{'root-domain'} ne '') {
+                # Process 'root-domain' option
+                $domain = $config{$host}{'root-domain'};
+                $sub_domain = $host;
+                $sub_domain =~ s/\.$domain//;
+
+                if (!defined($sub_domain)) {
+                    error("'root-domain' (%s) is not part of the full domain (%s)!", $domain, $host);
+                    next;
+                }
+                warning("%s has both 'root-domain' and 'on-root-domain' defined. The latter is ignored") if $config{$host}{'on-root-domain'};
             }
+            else {
+                # Process legacy 'on-root-domain' option
+                if ($config{$host}{'on-root-domain'}) {
+                    $sub_domain = '';
+                    $domain = $host;
+                } else {
+                    ($sub_domain, $domain) = split(/\./, $host, 2);
+                }
+            }
+
             info("setting %s address to %s for %s", $ipv, $ip, $host);
             verbose("UPDATE:","updating %s", $host);