Fabio/ddclient
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

porkbun: Invert condition to improve readability

Browse source
This commit is contained in:
Richard Hansen 2024-07-23 01:56:19 -04:00
parent d8a23ff9a4
commit 536c7c87a2
1 changed files with 35 additions and 37 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

72
ddclient.in
View file

@ -6819,46 +6819,44 @@ sub nic_porkbun_update {
next; next;
} }
my $records = $response->{records}; my $records = $response->{records};
if (ref($records) eq 'ARRAY' && defined $records->[0]->{'id'}) { if (ref($records) ne 'ARRAY' || !defined($records->[0]{'id'})) {
warning("$h: There are multiple applicable records. Only first record is used. Overwrite all with the same content.")
if @$records > 1;
if ($records->[0]{'content'} eq $ip) {
$config{$h}{"status-ipv$ipv"} = "good";
success("$h: skipped: IPv$ipv address was already set to $ip");
next;
}
my $ttl = $records->[0]->{'ttl'};
my $notes = $records->[0]->{'notes'};
debug("ttl = %s", $ttl);
debug("notes = %s", $notes);
$reply = geturl(
proxy => opt('proxy'),
url => "https://porkbun.com/api/json/v3/dns/editByNameType/$domain/$rrset_type/$sub_domain",
headers => ['Content-Type: application/json'],
method => 'POST',
data => encode_json({
secretapikey => $config{$h}{'secretapikey'},
apikey => $config{$h}{'apikey'},
content => $ip,
ttl => $ttl,
notes => $notes,
}),
);
if (!defined($reply) || !$reply) {
failed("$h: request to porkbun.com failed");
next;
}
if (!header_ok($h, $reply)) {
failed("$h: $reply");
next;
}
$config{$h}{"status-ipv$ipv"} = "good";
success("$h: IPv%s address set to $ip");
next;
} else {
failed("$h: no applicable existing records"); failed("$h: no applicable existing records");
next; next;
} }
warning("$h: There are multiple applicable records. Only first record is used. Overwrite all with the same content.")
if @$records > 1;
if ($records->[0]{'content'} eq $ip) {
$config{$h}{"status-ipv$ipv"} = "good";
success("$h: skipped: IPv$ipv address was already set to $ip");
next;
}
my $ttl = $records->[0]->{'ttl'};
my $notes = $records->[0]->{'notes'};
debug("ttl = %s", $ttl);
debug("notes = %s", $notes);
$reply = geturl(
proxy => opt('proxy'),
url => "https://porkbun.com/api/json/v3/dns/editByNameType/$domain/$rrset_type/$sub_domain",
headers => ['Content-Type: application/json'],
method => 'POST',
data => encode_json({
secretapikey => $config{$h}{'secretapikey'},
apikey => $config{$h}{'apikey'},
content => $ip,
ttl => $ttl,
notes => $notes,
}),
);
if (!defined($reply) || !$reply) {
failed("$h: request to porkbun.com failed");
next;
}
if (!header_ok($h, $reply)) {
failed("$h: $reply");
next;
}
$config{$h}{"status-ipv$ipv"} = "good";
success("$h: IPv%s address set to $ip");
} }
} }
} }