From ad95fd46c2abba58aedadedec6aa3bc5bd461390 Mon Sep 17 00:00:00 2001 From: Richard Hansen Date: Mon, 6 Jul 2020 15:24:40 -0400 Subject: [PATCH 1/5] Install all core modules on CentOS/RHEL/Fedora CentOS and RHEL have a `perl-core` metapackage that depends on all packages providing core modules. Fedora's `perl` package is equivalent to the CentOS/RHEL `perl-core` package, and its `perl-interpreter` package is equivalent to the CentOS/RHEL `perl` package. --- .github/workflows/ci.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a110f52..f2ab9c4 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -57,7 +57,7 @@ jobs: steps: - uses: actions/checkout@v1 - name: install dependencies - run: yum install -y automake perl-Test-Simple + run: yum install -y automake perl-core - name: autogen run: ./autogen - name: configure @@ -73,7 +73,7 @@ jobs: steps: - uses: actions/checkout@v2 - name: install dependencies - run: dnf --enablerepo=PowerTools install -y perl-version automake make perl-Test-Warnings + run: dnf --enablerepo=PowerTools install -y automake make perl-Test-Warnings perl-core - name: autogen run: ./autogen - name: configure @@ -89,7 +89,7 @@ jobs: steps: - uses: actions/checkout@v2 - name: install dependencies - run: dnf install -y automake findutils make perl-Test-Warnings perl-version + run: dnf install -y automake findutils make perl perl-Test-Warnings - name: autogen run: ./autogen - name: configure @@ -107,7 +107,7 @@ jobs: steps: - uses: actions/checkout@v2 - name: install dependencies - run: yum install -y perl-version automake make perl-Test-Simple + run: yum install -y automake make perl-core - name: autogen run: ./autogen - name: configure From 34e5cbd97f2034d6284e56828bc9cccf93ce50ab Mon Sep 17 00:00:00 2001 From: Richard Hansen Date: Mon, 6 Jul 2020 15:40:42 -0400 Subject: [PATCH 2/5] Rename `test-redhat` to `test-redhat-ubi7` --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f2ab9c4..64541f6 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -99,7 +99,7 @@ jobs: - name: distcheck run: make VERBOSE=1 distcheck - test-redhat: + test-redhat-ubi7: runs-on: ubuntu-latest # we use redhats univeral base image which is not available on docker hub # https://catalog.redhat.com/software/containers/ubi7/ubi/5c3592dcd70cc534b3a37814 From 5aa4fe71da6f86893633e8a2f5459a9aa40e42aa Mon Sep 17 00:00:00 2001 From: Richard Hansen Date: Mon, 6 Jul 2020 15:42:26 -0400 Subject: [PATCH 3/5] Pass `--refresh` to `dnf` Hopefully this will stop the "Downloading successful, but checksum doesn't match" errors we occasionally see for Fedora. --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 64541f6..91ade94 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -73,7 +73,7 @@ jobs: steps: - uses: actions/checkout@v2 - name: install dependencies - run: dnf --enablerepo=PowerTools install -y automake make perl-Test-Warnings perl-core + run: dnf --refresh --enablerepo=PowerTools install -y automake make perl-Test-Warnings perl-core - name: autogen run: ./autogen - name: configure @@ -89,7 +89,7 @@ jobs: steps: - uses: actions/checkout@v2 - name: install dependencies - run: dnf install -y automake findutils make perl perl-Test-Warnings + run: dnf --refresh install -y automake findutils make perl perl-Test-Warnings - name: autogen run: ./autogen - name: configure From 1b63ae50c9abb48a1860efa5324d88ad8faed35c Mon Sep 17 00:00:00 2001 From: Richard Hansen Date: Mon, 6 Jul 2020 15:59:30 -0400 Subject: [PATCH 4/5] Colorize test results --- .github/workflows/ci.yml | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 91ade94..df397c6 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -45,9 +45,9 @@ jobs: - name: configure run: ./configure - name: check - run: make VERBOSE=1 check + run: make VERBOSE=1 AM_COLOR_TESTS=always check - name: distcheck - run: make VERBOSE=1 distcheck + run: make VERBOSE=1 AM_COLOR_TESTS=always distcheck - name: distribution tarball is complete run: ./.github/workflows/scripts/dist-tarball-check @@ -63,9 +63,9 @@ jobs: - name: configure run: ./configure - name: check - run: make VERBOSE=1 check + run: make VERBOSE=1 AM_COLOR_TESTS=always check - name: distcheck - run: make VERBOSE=1 distcheck + run: make VERBOSE=1 AM_COLOR_TESTS=always distcheck test-centos8: runs-on: ubuntu-latest @@ -79,9 +79,9 @@ jobs: - name: configure run: ./configure - name: check - run: make VERBOSE=1 check + run: make VERBOSE=1 AM_COLOR_TESTS=always check - name: distcheck - run: make VERBOSE=1 distcheck + run: make VERBOSE=1 AM_COLOR_TESTS=always distcheck test-fedora: runs-on: ubuntu-latest @@ -95,9 +95,9 @@ jobs: - name: configure run: ./configure - name: check - run: make VERBOSE=1 check + run: make VERBOSE=1 AM_COLOR_TESTS=always check - name: distcheck - run: make VERBOSE=1 distcheck + run: make VERBOSE=1 AM_COLOR_TESTS=always distcheck test-redhat-ubi7: runs-on: ubuntu-latest @@ -113,6 +113,6 @@ jobs: - name: configure run: ./configure - name: check - run: make VERBOSE=1 check + run: make VERBOSE=1 AM_COLOR_TESTS=always check - name: distcheck - run: make VERBOSE=1 distcheck + run: make VERBOSE=1 AM_COLOR_TESTS=always distcheck From f11fef5c50f29165420788d2d459adf99b45fc07 Mon Sep 17 00:00:00 2001 From: Richard Hansen Date: Mon, 6 Jul 2020 16:09:29 -0400 Subject: [PATCH 5/5] Install modules for testing on CentOS/RHEL/Fedora --- .github/workflows/ci.yml | 41 ++++++++++++++++++++++++++++++++++++---- 1 file changed, 37 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index df397c6..ca6d200 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -57,7 +57,13 @@ jobs: steps: - uses: actions/checkout@v1 - name: install dependencies - run: yum install -y automake perl-core + run: | + yum install -y \ + automake \ + perl-IO-Socket-INET6 \ + perl-core \ + perl-libwww-perl \ + ; - name: autogen run: ./autogen - name: configure @@ -73,7 +79,15 @@ jobs: steps: - uses: actions/checkout@v2 - name: install dependencies - run: dnf --refresh --enablerepo=PowerTools install -y automake make perl-Test-Warnings perl-core + run: | + dnf --refresh --enablerepo=PowerTools install -y \ + automake \ + make \ + perl-HTTP-Daemon \ + perl-IO-Socket-INET6 \ + perl-Test-Warnings \ + perl-core \ + ; - name: autogen run: ./autogen - name: configure @@ -89,7 +103,19 @@ jobs: steps: - uses: actions/checkout@v2 - name: install dependencies - run: dnf --refresh install -y automake findutils make perl perl-Test-Warnings + run: | + dnf --refresh install -y \ + automake \ + findutils \ + make \ + perl \ + perl-HTTP-Daemon \ + perl-HTTP-Daemon-SSL \ + perl-IO-Socket-INET6 \ + perl-Plack \ + perl-Test-TCP \ + perl-Test-Warnings \ + ; - name: autogen run: ./autogen - name: configure @@ -107,7 +133,14 @@ jobs: steps: - uses: actions/checkout@v2 - name: install dependencies - run: yum install -y automake make perl-core + run: | + yum install -y \ + automake \ + make \ + perl-HTTP-Daemon \ + perl-IO-Socket-INET6 \ + perl-core \ + ; - name: autogen run: ./autogen - name: configure