Fabio/ddclient
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

dnsexit2: Convert string interpolation to sprintf format specifier

Browse source 
Rationale:
  * For consistency.
  * It's generally not a good idea to mix interpolation with `sprintf`
    because the interpolated string itself might coincidentally (or
    maliciously) contain format specifiers.
This commit is contained in:
Richard Hansen 2024-05-29 17:10:06 -04:00
parent 6cdf5da9f4
commit 3a5e86b4d2
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
ddclient.in
View file

@ -4196,7 +4196,7 @@ sub nic_dnsexit2_update {
my $ipv = ($ip eq ($ipv6 // '')) ? '6' : '4';
my $type = ($ip eq ($ipv6 // '')) ? 'AAAA' : 'A';
info("Going to update IPv$ipv address to %s for %s.", $ip, $h);
info("Going to update IPv%s address to %s for %s.", $ipv, $ip, $h);
$config{$h}{'status-ipv$ipv'} = 'failed';
$total_payload{$ipv} = {
name => $h,
@ -4295,7 +4295,7 @@ sub nic_dnsexit2_update {
$config{$h}{"ipv$ipv"} = $total_payload{$ipv}{content};
$config{$h}{"status-ipv$ipv"} = 'good';
success("%s", $message);
success("Updated %s successfully to IPv$ipv address %s at time %s", $h, $total_payload{$ipv}{content}, prettytime($config{$h}{'mtime'}));
success("Updated %s successfully to IPv%s address %s at time %s", $h, $ipv, $total_payload{$ipv}{content}, prettytime($config{$h}{'mtime'}));
}
} elsif ($status eq 'warning') {
warning("%s", $message);