Fabio/ddclient
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Delete --geturl command-line argument and geturl option

Browse source 
They are not used in any tests, and `curl` is a better choice anyway.
This commit is contained in:
Richard Hansen 2024-07-19 18:01:30 -04:00
parent dab67eae69
commit 3a57ca1374
2 changed files with 2 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ChangeLog.md
View file

@ -41,6 +41,8 @@ repository history](https://github.com/ddclient/ddclient/commits/master).
* `dyndns2`: The obsolete `static` and `custom` options have been removed. * `dyndns2`: The obsolete `static` and `custom` options have been removed.
Setting the options may produce a warning. Setting the options may produce a warning.
[#709](https://github.com/ddclient/ddclient/pull/709) [#709](https://github.com/ddclient/ddclient/pull/709)
* The diagnostic `--geturl` command-line argument was removed.
[#TODO](https://github.com/ddclient/ddclient/pull/TODO)
### New features ### New features

20
ddclient.in
View file

@ -618,7 +618,6 @@ our %variables = (
'quiet' => setv(T_BOOL, 0, 0, 0, undef), 'quiet' => setv(T_BOOL, 0, 0, 0, undef),
'help' => setv(T_BOOL, 0, 0, 0, undef), 'help' => setv(T_BOOL, 0, 0, 0, undef),
'test' => setv(T_BOOL, 0, 0, 0, undef), 'test' => setv(T_BOOL, 0, 0, 0, undef),
'geturl' => setv(T_STRING,0, 0, undef, undef),
'postscript' => setv(T_POSTS, 0, 0, undef, undef), 'postscript' => setv(T_POSTS, 0, 0, undef, undef),
'ssl_ca_dir' => setv(T_FILE, 0, 0, undef, undef), 'ssl_ca_dir' => setv(T_FILE, 0, 0, undef, undef),
@ -1303,7 +1302,6 @@ my @opt = (
["fw-banlocal", "!", ""], ## deprecated ["fw-banlocal", "!", ""], ## deprecated
["if-skip", "=s", ""], ## deprecated ["if-skip", "=s", ""], ## deprecated
["test", "!", ""], ## hidden ["test", "!", ""], ## hidden
["geturl", "=s", ""], ## hidden
["redirect", "=i", "--redirect=<max> : enable and follow at most <max> HTTP 30x redirections"], ["redirect", "=i", "--redirect=<max> : enable and follow at most <max> HTTP 30x redirections"],
"", "",
nic_examples(), nic_examples(),
@ -1315,9 +1313,6 @@ sub main {
$saved_recap = ''; $saved_recap = '';
%saved_opt = %opt; %saved_opt = %opt;
$result = 'OK'; $result = 'OK';
test_geturl(opt('geturl')) if opt('geturl');
if (opt('help')) { if (opt('help')) {
printf "%s\n", $opt_usage; printf "%s\n", $opt_usage;
$opt{'version'}('', ''); $opt{'version'}('', '');
@ -2272,22 +2267,7 @@ sub test_possible_ip {
exit 0 unless opt('debug'); exit 0 unless opt('debug');
} }
######################################################################
## test_geturl - print (and save if -test) result of fetching a URL
######################################################################
sub test_geturl {
my $url = shift;
my $reply = geturl(
proxy => opt('proxy'),
url => $url,
login => opt('login'),
password => opt('password'),
);
print "URL $url\n";
print $reply // "<undefined>\n";
exit;
}
###################################################################### ######################################################################
## load_file ## load_file
###################################################################### ######################################################################