Fabio/ddclient
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix syntax

Browse source
This commit is contained in:
philippderdiedas 2024-07-19 22:28:59 +00:00
parent fcaffb09a7
commit 3477e36b88
1 changed files with 47 additions and 48 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

95
ddclient.in
View file

@ -6406,12 +6406,52 @@ sub nic_hetzner_update {
info("updating %s: setting IPv$ipv address to %s", $domain, $ip); info("updating %s: setting IPv$ipv address to %s", $domain, $ip);
$config{$domain}{"status-ipv$ipv"} = 'failed'; $config{$domain}{"status-ipv$ipv"} = 'failed';
# Get DNS 'A' or 'AAAA' record ID # Get DNS 'A' or 'AAAA' record ID
$url = "https://$config{$domain}{'server'}/records?zone_id=$zone_id"; $url = "https://$config{$domain}{'server'}/records?zone_id=$zone_id";
$reply = geturl(proxy => opt('proxy'),
url => $url,
headers => $headers
);
unless ($reply && header_ok($domain, $reply)) {
failed("updating %s: Could not connect to %s.", $domain, $config{$domain}{'server'});
next;
}
# Strip header
$reply =~ qr/{(?:[^{}]*|(?R))*}/mp;
$response = eval {decode_json(${^MATCH})};
unless ($response && $response->{records}) {
failed("updating %s: invalid json or result.", $domain);
next;
}
# Pull the ID out of the json, messy
my ($dns_rec_id, $current_ip) = map { ($_->{name} eq $hostname && $_->{type} eq $type) ? ($_->{id}, $_ ->{value}) : ()} @{$response->{records}};
my $http_method="";
if ($current_ip && $current_ip eq $ip) {
info("updating %s %s: IP is already %s, no update needed.", $hostname, $ipv, $ip);
$config{$domain}{"ipv$ipv"} = $ip;
$config{$domain}{'mtime'} = $now;
$config{$domain}{"status-ipv$ipv"} = 'good';
} else {
# Set domain
if ($dns_rec_id)
{
debug("updating %s: DNS '$type' record ID: $dns_rec_id", $domain);
$url = "https://$config{$domain}{'server'}/records/$dns_rec_id";
$http_method = "PUT";
} else {
debug("creating %s: DNS '$type'", $domain);
$url = "https://$config{$domain}{'server'}/records";
$http_method = "POST";
}
my $data = "{\"zone_id\":\"$zone_id\", \"name\": \"$hostname\", \"value\": \"$ip\", \"type\": \"$type\", \"ttl\": $config{$domain}{'ttl'}}";
$reply = geturl(proxy => opt('proxy'), $reply = geturl(proxy => opt('proxy'),
url => $url, url => $url,
headers => $headers headers => $headers,
); method => $http_method,
data => $data
);
unless ($reply && header_ok($domain, $reply)) { unless ($reply && header_ok($domain, $reply)) {
failed("updating %s: Could not connect to %s.", $domain, $config{$domain}{'server'}); failed("updating %s: Could not connect to %s.", $domain, $config{$domain}{'server'});
next; next;
@ -6419,54 +6459,13 @@ sub nic_hetzner_update {
# Strip header # Strip header
$reply =~ qr/{(?:[^{}]*|(?R))*}/mp; $reply =~ qr/{(?:[^{}]*|(?R))*}/mp;
$response = eval {decode_json(${^MATCH})}; $response = eval {decode_json(${^MATCH})};
unless ($response && $response->{records}) { if ($response && $response->{record}) {
failed("updating %s: invalid json or result.", $domain); success("updating %s: IPv$ipv address set to %s", $domain, $ip);
next;
}
# Pull the ID out of the json, messy
my ($dns_rec_id, $current_ip) = map { ($_->{name} eq $hostname && $_->{type} eq $type) ? ($_->{id}, $_ ->{value}) : ()} @{$response->{records}};
my $http_method="";
if ($current_ip && $current_ip eq $ip) {
info("updating %s %s: IP is already %s, no update needed.", $hostname, $ipv, $ip);
$config{$domain}{"ipv$ipv"} = $ip; $config{$domain}{"ipv$ipv"} = $ip;
$config{$domain}{'mtime'} = $now; $config{$domain}{'mtime'} = $now;
$config{$domain}{"status-ipv$ipv"} = 'good'; $config{$domain}{"status-ipv$ipv"} = 'good';
} else { } else {
# Set domain failed("updating %s: invalid json or result.", $domain);
if ($dns_rec_id)
{
debug("updating %s: DNS '$type' record ID: $dns_rec_id", $domain);
$url = "https://$config{$domain}{'server'}/records/$dns_rec_id";
$http_method = "PUT";
} else {
debug("creating %s: DNS '$type'", $domain);
$url = "https://$config{$domain}{'server'}/records";
$http_method = "POST";
}
my $data = "{\"zone_id\":\"$zone_id\", \"name\": \"$hostname\", \"value\": \"$ip\", \"type\": \"$type\", \"ttl\": $config{$domain}{'ttl'}}";
$reply = geturl(proxy => opt('proxy'),
url => $url,
headers => $headers,
method => $http_method,
data => $data
);
unless ($reply && header_ok($domain, $reply)) {
failed("updating %s: Could not connect to %s.", $domain, $config{$domain}{'server'});
next;
}
# Strip header
$reply =~ qr/{(?:[^{}]*|(?R))*}/mp;
$response = eval {decode_json(${^MATCH})};
if ($response && $response->{record}) {
success("updating %s: IPv$ipv address set to %s", $domain, $ip);
$config{$domain}{"ipv$ipv"} = $ip;
$config{$domain}{'mtime'} = $now;
$config{$domain}{"status-ipv$ipv"} = 'good';
} else {
failed("updating %s: invalid json or result.", $domain);
}
} }
} }
} }