From 26f57bf36aa46f5863610322be9183bd2b83d03a Mon Sep 17 00:00:00 2001 From: Richard Hansen Date: Thu, 18 Jul 2024 05:25:05 -0400 Subject: [PATCH] dyndns2: Delete obsolete(?) "wait" response handling --- ChangeLog.md | 4 ++++ ddclient.in | 15 --------------- 2 files changed, 4 insertions(+), 15 deletions(-) diff --git a/ChangeLog.md b/ChangeLog.md index 19633f3..b531974 100644 --- a/ChangeLog.md +++ b/ChangeLog.md @@ -34,6 +34,10 @@ repository history](https://github.com/ddclient/ddclient/commits/master). * Deprecated built-in web IP discovery services are not listed in the output of `--list-web-services`. [#682](https://github.com/ddclient/ddclient/pull/682) + * `dyndns2`: Support for "wait" response lines has been removed. The Dyn + documentation does not mention such responses, and the code to handle them, + untouched since at least 2006, is believed to be obsolete. + [#709](https://github.com/ddclient/ddclient/pull/709) ### New features diff --git a/ddclient.in b/ddclient.in index e5292f5..d60f87d 100755 --- a/ddclient.in +++ b/ddclient.in @@ -4161,21 +4161,6 @@ sub nic_dyndns2_update { if ($status ne 'good') { if (exists($errors{$status})) { failed("$hosts: $status: $errors{$status}"); - } elsif ($status =~ qr/w(\d+)(.)/) { - # TODO: does not mention - # anything about wait statuses. Is this obsolete (this code has been here - # since at least 2006)? Or does a different DynDNS-like service emit wait - # lines? - my ($wait, $units) = ($1, lc $2); - my ($sec, $scale) = ($wait, 1); - ($scale, $units) = (1, 'seconds') if $units eq 's'; - ($scale, $units) = (60, 'minutes') if $units eq 'm'; - ($scale, $units) = (60*60, 'hours') if $units eq 'h'; - $sec = $wait * $scale; - for my $h (@hosts) { - $config{$h}{'wtime'} = $now + $sec; - } - warning("$hosts: wait $wait $units before further updates"); } else { failed("$hosts: unexpected status: $line"); }