Static code analysis using PMD
I haven't tested that results. For me the diffs looking well and useful.
The future will show if we need all this rules, drop some or add more.
PMD allows checking code for violation and quickstart provides a ruleset
which are "rules that are most likely to apply everywhere". Violated
rules are disabled to get started.
Some bicycle routes can have portions which are not accessible.
Potential reasons for this:
- temporary construction work on the ways (sometimes for months),
- local access change without simultaneous update of bicycle route relation
(lack of mapper's knowledge or lack of time to redefine an updated route),
- ...
This commit changes the fastbike profile so that being on a cycle route does
not automatically mean "access granted" for bicycles. The normal access
checkings are used instead.
However, the accesspenalty is set to 15 if the no-access way belongs to such a
route, so that the way is not completely forbidden if there is no other
alternative unavailable.
Some bicycle routes can have portions which are not accessible.
Potential reasons for this:
- temporary construction work on the ways (sometimes for months),
- local access change without simultaneous update of bicycle route relation
(lack of mapper's knowledge or lack of time to redefine an updated route),
- ...
This commit changes the trekking profile so that being on a cycle route does
not automatically mean "access granted" for bicycles. The normal access
checkings are used instead.
However, the accesspenalty is set to 15 if the no-access way belongs to such a
route, so that the way is not completely forbidden if there is no other
alternative unavailable.
