Enable PMD rule UnnecessaryImport and fix violations

brouter-core/src/main/java/btools/router/OsmPrePath.java

@@ -7,7 +7,6 @@ package btools.router;
 
 import btools.mapaccess.OsmLink;
 import btools.mapaccess.OsmNode;
-import btools.mapaccess.OsmTransferNode;
 
 public abstract class OsmPrePath {
   protected OsmNode sourceNode;

brouter-core/src/main/java/btools/router/VoiceHintList.java

@@ -7,7 +7,6 @@
 package btools.router;
 
 import java.util.ArrayList;
-import java.util.List;
 
 public class VoiceHintList {
   private String transportMode;

brouter-core/src/test/java/btools/router/OsmNodeNamedTest.java

@@ -1,11 +1,7 @@
 package btools.router;
 
 import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertFalse;
-import static org.junit.Assert.assertTrue;
 
-import org.junit.AfterClass;
-import org.junit.BeforeClass;
 import org.junit.Test;
 
 import btools.util.CheapRuler;

brouter-expressions/src/main/java/btools/expressions/BExpressionMetaData.java

@@ -9,16 +9,7 @@ package btools.expressions;
 import java.io.BufferedReader;
 import java.io.File;
 import java.io.FileReader;
-import java.util.ArrayList;
-import java.util.Arrays;
 import java.util.HashMap;
-import java.util.List;
-import java.util.Map;
-import java.util.StringTokenizer;
-import java.util.TreeMap;
-
-import btools.util.BitCoderContext;
-import btools.util.Crc32;
 
 
 public final class BExpressionMetaData {

brouter-expressions/src/main/java/btools/expressions/IntegrityCheckProfile.java

@@ -1,7 +1,6 @@
 package btools.expressions;
 
 import java.io.File;
-import java.io.IOException;
 
 public class IntegrityCheckProfile {
 

brouter-expressions/src/test/java/btools/expressions/EncodeDecodeTest.java

@@ -1,12 +1,11 @@
 package btools.expressions;
 
-import java.util.*;
-import java.io.*;
-import java.net.URL;
-
 import org.junit.Assert;
 import org.junit.Test;
 
+import java.io.File;
+import java.net.URL;
+
 public class EncodeDecodeTest {
   @Test
   public void encodeDecodeTest() {

brouter-map-creator/src/main/java/btools/mapcreator/RelationStatistics.java

@@ -5,9 +5,6 @@ import java.io.EOFException;
 import java.io.File;
 import java.util.HashMap;
 
-import btools.util.DenseLongMap;
-import btools.util.TinyDenseLongMap;
-
 /**
  * WayCutter does 2 step in map-processing:
  * <p>

brouter-map-creator/src/test/java/btools/mapcreator/MapcreatorTest.java

@@ -1,13 +1,10 @@
 package btools.mapcreator;
 
-import java.util.Random;
-import java.util.HashMap;
-
 import org.junit.Assert;
 import org.junit.Test;
 
-import java.net.URL;
 import java.io.File;
+import java.net.URL;
 
 public class MapcreatorTest {
   @Test

brouter-mapaccess/src/main/java/btools/mapaccess/DirectWeaver.java

@@ -8,7 +8,6 @@ import btools.codec.TagValueValidator;
 import btools.codec.TagValueWrapper;
 import btools.codec.WaypointMatcher;
 import btools.util.ByteDataWriter;
-import btools.util.IByteArrayUnifier;
 
 /**
  * DirectWeaver does the same decoding as MicroCache2, but decodes directly

brouter-mapaccess/src/main/java/btools/mapaccess/MatchedWaypoint.java

@@ -9,8 +9,6 @@ import java.io.DataInput;
 import java.io.DataOutput;
 import java.io.IOException;
 
-import btools.mapaccess.OsmNode;
-
 public final class MatchedWaypoint {
   public OsmNode node1;
   public OsmNode node2;

brouter-mapaccess/src/main/java/btools/mapaccess/OsmNodesMap.java

@@ -9,7 +9,6 @@ import java.util.ArrayList;
 import java.util.HashMap;
 
 import btools.util.ByteArrayUnifier;
-import btools.util.SortedHeap;
 
 public final class OsmNodesMap {
   private HashMap<OsmNode, OsmNode> hmap = new HashMap<OsmNode, OsmNode>(4096);

brouter-mapaccess/src/main/java/btools/mapaccess/WaypointMatcherImpl.java

@@ -3,8 +3,6 @@ package btools.mapaccess;
 import java.util.List;
 
 import btools.codec.WaypointMatcher;
-import btools.mapaccess.OsmNode;
-import btools.mapaccess.OsmNodePairSet;
 import btools.util.CheapRuler;
 
 /**

brouter-server/src/main/java/btools/server/request/ServerHandler.java

@@ -1,12 +1,5 @@
 package btools.server.request;
 
-import btools.mapaccess.OsmNode;
-import btools.router.OsmNodeNamed;
-import btools.router.OsmNogoPolygon;
-import btools.router.OsmTrack;
-import btools.router.RoutingContext;
-import btools.server.ServiceContext;
-
 import java.io.BufferedWriter;
 import java.io.File;
 import java.io.StringWriter;
@@ -14,6 +7,12 @@ import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.List;
 
+import btools.router.OsmNodeNamed;
+import btools.router.OsmNogoPolygon;
+import btools.router.OsmTrack;
+import btools.router.RoutingContext;
+import btools.server.ServiceContext;
+
 /**
  * URL query parameter handler for web and standalone server. Supports all
  * BRouter features without restrictions.

brouter-util/src/main/java/btools/util/SortedHeap.java

@@ -1,7 +1,5 @@
 package btools.util;
 
-import java.util.Random;
-
 /**
  * Memory efficient and lightning fast heap to get the lowest-key value of a set of key-object pairs
  *

brouter-util/src/test/java/btools/util/ByteDataIOTest.java

@@ -1,8 +1,5 @@
 package btools.util;
 
-import java.util.Random;
-import java.util.HashSet;
-
 import org.junit.Assert;
 import org.junit.Test;
 

brouter-util/src/test/java/btools/util/CheapAngleMeterTest.java

@@ -1,11 +1,7 @@
 package btools.util;
 
 import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertFalse;
-import static org.junit.Assert.assertTrue;
 
-import org.junit.AfterClass;
-import org.junit.BeforeClass;
 import org.junit.Test;
 
 public class CheapAngleMeterTest {

brouter-util/src/test/java/btools/util/ReducedMedianFilterTest.java

@@ -1,11 +1,10 @@
 package btools.util;
 
-import java.util.Random;
-import java.io.*;
-
 import org.junit.Assert;
 import org.junit.Test;
 
+import java.io.IOException;
+
 public class ReducedMedianFilterTest {
   @Test
   public void reducedMedianFilterTest() throws IOException {

brouter-util/src/test/java/btools/util/SortedHeapTest.java

@@ -1,12 +1,10 @@
 package btools.util;
 
-import java.util.Random;
-import java.util.HashMap;
-import java.util.HashSet;
-
 import org.junit.Assert;
 import org.junit.Test;
 
+import java.util.Random;
+
 public class SortedHeapTest {
   @Test
   public void sortedHeapTest1() {

config/pmd/pmd-ruleset.xml

@@ -40,7 +40,6 @@
         <exclude name="UncommentedEmptyConstructor" />
         <exclude name="UncommentedEmptyMethodBody" />
         <exclude name="UnnecessaryFullyQualifiedName" />
-        <exclude name="UnnecessaryImport" />
         <exclude name="UnnecessaryModifier" />
         <exclude name="UnnecessaryReturn" />
         <exclude name="UnusedFormalParameter" />