Fabio/brouter
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Enable PMD rule AvoidInstanceofChecksInCatchClause and fix violations

Browse source
This commit is contained in:
Manuel Fuhr 2022-11-13 12:56:50 +01:00
parent 30be64cbbe
commit 1bff48b649
2 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
brouter-expressions/src/main/java/btools/expressions/BExpressionContext.java
View file

@ -805,10 +805,9 @@ public abstract class BExpressionContext implements IByteArrayUnifier {
for (int i = 0; i < minWriteIdx; i++) { for (int i = 0; i < minWriteIdx; i++) {
variableData[i] = readOnlyData[i]; variableData[i] = readOnlyData[i];
} }
} catch (Exception e) { } catch (IllegalArgumentException e) {
if (e instanceof IllegalArgumentException) {
throw new IllegalArgumentException("ParseException " + file + " at line " + linenr + ": " + e.getMessage()); throw new IllegalArgumentException("ParseException " + file + " at line " + linenr + ": " + e.getMessage());
} } catch (Exception e) {
throw new RuntimeException(e); throw new RuntimeException(e);
} }
if (expressionList.size() == 0) { if (expressionList.size() == 0) {

1
config/pmd/pmd-ruleset.xml
View file

@ -14,7 +14,6 @@
<exclude name="AssignmentToNonFinalStatic" /> <exclude name="AssignmentToNonFinalStatic" />
<exclude name="AvoidBranchingStatementAsLastInLoop" /> <exclude name="AvoidBranchingStatementAsLastInLoop" />
<exclude name="AvoidCatchingThrowable" /> <exclude name="AvoidCatchingThrowable" />
<exclude name="AvoidInstanceofChecksInCatchClause" />
<exclude name="AvoidProtectedFieldInFinalClass" /> <exclude name="AvoidProtectedFieldInFinalClass" />
<exclude name="AvoidUsingVolatile" /> <exclude name="AvoidUsingVolatile" />
<exclude name="CloseResource" /> <exclude name="CloseResource" />