From f8fefe1b4fc15ecd85480f04319438322a349174 Mon Sep 17 00:00:00 2001 From: Thibault Deckers Date: Wed, 11 May 2022 16:38:53 +0900 Subject: [PATCH] minor --- lib/ref/mime_types.dart | 2 ++ lib/services/media/media_file_service.dart | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/ref/mime_types.dart b/lib/ref/mime_types.dart index 185165bec..2fba09ac6 100644 --- a/lib/ref/mime_types.dart +++ b/lib/ref/mime_types.dart @@ -82,6 +82,8 @@ class MimeTypes { static bool isVideo(String mimeType) => mimeType.startsWith('video'); + static bool isVisual(String mimeType) => isImage(mimeType) || isVideo(mimeType); + static bool refersToSameType(String a, b) { switch (a) { case avi: diff --git a/lib/services/media/media_file_service.dart b/lib/services/media/media_file_service.dart index 00020a2de..57b147459 100644 --- a/lib/services/media/media_file_service.dart +++ b/lib/services/media/media_file_service.dart @@ -211,7 +211,7 @@ class PlatformMediaFileService implements MediaFileService { // `await` here, so that `completeError` will be caught below return await completer.future; } on PlatformException catch (e, stack) { - if (!MimeTypes.knownMediaTypes.contains(mimeType)) { + if (!MimeTypes.knownMediaTypes.contains(mimeType) && MimeTypes.isVisual(mimeType)) { await reportService.recordError(e, stack); } } @@ -285,7 +285,7 @@ class PlatformMediaFileService implements MediaFileService { }); if (result != null) return result as Uint8List; } on PlatformException catch (e, stack) { - if (!MimeTypes.knownMediaTypes.contains(mimeType)) { + if (!MimeTypes.knownMediaTypes.contains(mimeType) && MimeTypes.isVisual(mimeType)) { await reportService.recordError(e, stack); } }