static analysis fix

This commit is contained in:
Thibault Deckers 2020-10-13 16:24:40 +09:00
parent 80d95608a1
commit e7f0b40602
2 changed files with 4 additions and 6 deletions

View file

@ -387,7 +387,7 @@ class ImageEntry {
final newFields = await ImageFileService.rename(this, '$newName$extension');
if (newFields.isEmpty) return false;
_applyNewFields(newFields);
await _applyNewFields(newFields);
_bestTitle = null;
metadataChangeNotifier.notifyListeners();
return true;
@ -400,7 +400,7 @@ class ImageEntry {
final oldDateModifiedSecs = dateModifiedSecs;
final oldRotationDegrees = rotationDegrees;
final oldIsFlipped = isFlipped;
_applyNewFields(newFields);
await _applyNewFields(newFields);
await _onImageChanged(oldDateModifiedSecs, oldRotationDegrees, oldIsFlipped);
return true;
}
@ -412,7 +412,7 @@ class ImageEntry {
final oldDateModifiedSecs = dateModifiedSecs;
final oldRotationDegrees = rotationDegrees;
final oldIsFlipped = isFlipped;
_applyNewFields(newFields);
await _applyNewFields(newFields);
await _onImageChanged(oldDateModifiedSecs, oldRotationDegrees, oldIsFlipped);
return true;
}

View file

@ -57,9 +57,7 @@ class ImageView extends StatelessWidget {
// if the hero tag wraps the whole `PhotoView` and the `loadingBuilder` is not provided,
// there's a black frame between the hero animation and the final image, even when it's cached.
final fastThumbnailProvider = ThumbnailProvider(
ThumbnailProviderKey.fromEntry(entry)
);
final fastThumbnailProvider = ThumbnailProvider(ThumbnailProviderKey.fromEntry(entry));
// this loading builder shows a transition image until the final image is ready
// if the image is already in the cache it will show the final image, otherwise the thumbnail
// in any case, we should use `Center` + `AspectRatio` + `Fill` so that the transition image