Fabio/aves
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

minor fixes

Browse source
This commit is contained in:
Thibault Deckers 2020-10-13 23:05:25 +09:00
parent 4c21c67f50
commit e578caa4d5
2 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
lib/model/settings/settings.dart
View file

@ -110,7 +110,9 @@ class Settings extends ChangeNotifier {
double get collectionTileExtent => _prefs.getDouble(collectionTileExtentKey) ?? 0; double get collectionTileExtent => _prefs.getDouble(collectionTileExtentKey) ?? 0;
set collectionTileExtent(double newValue) => setAndNotify(collectionTileExtentKey, newValue); // do not notify, as `collectionTileExtent` is only used internally by `TileExtentManager`
// and should not trigger rebuilding by change notification
set collectionTileExtent(double newValue) => setAndNotify(collectionTileExtentKey, newValue, notify: false);
bool get showThumbnailLocation => getBoolOrDefault(showThumbnailLocationKey, true); bool get showThumbnailLocation => getBoolOrDefault(showThumbnailLocationKey, true);
@ -189,7 +191,7 @@ class Settings extends ChangeNotifier {
return _prefs.getStringList(key)?.map((s) => values.firstWhere((el) => el.toString() == s, orElse: () => null))?.where((el) => el != null)?.toList() ?? defaultValue; return _prefs.getStringList(key)?.map((s) => values.firstWhere((el) => el.toString() == s, orElse: () => null))?.where((el) => el != null)?.toList() ?? defaultValue;
} }
void setAndNotify(String key, dynamic newValue) { void setAndNotify(String key, dynamic newValue, {bool notify = true}) {
var oldValue = _prefs.get(key); var oldValue = _prefs.get(key);
if (newValue == null) { if (newValue == null) {
_prefs.remove(key); _prefs.remove(key);
@ -209,7 +211,7 @@ class Settings extends ChangeNotifier {
oldValue = _prefs.getBool(key); oldValue = _prefs.getBool(key);
_prefs.setBool(key, newValue); _prefs.setBool(key, newValue);
} }
if (oldValue != newValue) { if (oldValue != newValue && notify) {
notifyListeners(); notifyListeners();
} }
} }

1
lib/widgets/stats/stats.dart
View file

@ -64,6 +64,7 @@ class StatsPage extends StatelessWidget {
final videoByMimeTypes = Map.fromEntries(byMimeTypes.entries.where((kv) => kv.key.startsWith('video/'))); final videoByMimeTypes = Map.fromEntries(byMimeTypes.entries.where((kv) => kv.key.startsWith('video/')));
final mimeDonuts = Wrap( final mimeDonuts = Wrap(
alignment: WrapAlignment.center, alignment: WrapAlignment.center,
crossAxisAlignment: WrapCrossAlignment.center,
children: [ children: [
_buildMimeDonut(context, (sum) => Intl.plural(sum, one: 'image', other: 'images'), imagesByMimeTypes), _buildMimeDonut(context, (sum) => Intl.plural(sum, one: 'image', other: 'images'), imagesByMimeTypes),
_buildMimeDonut(context, (sum) => Intl.plural(sum, one: 'video', other: 'videos'), videoByMimeTypes), _buildMimeDonut(context, (sum) => Intl.plural(sum, one: 'video', other: 'videos'), videoByMimeTypes),