From d5e702266f6805dbbb5c5dc6e30932108d0e82ea Mon Sep 17 00:00:00 2001 From: Thibault Deckers Date: Mon, 30 Jan 2023 13:58:23 +0100 Subject: [PATCH] minor --- lib/widgets/collection/grid/headers/any.dart | 2 +- lib/widgets/common/map/leaflet/map.dart | 2 +- lib/widgets/debug/android_codecs.dart | 2 +- lib/widgets/debug/android_dirs.dart | 2 +- lib/widgets/debug/database.dart | 18 +++++++++--------- lib/widgets/debug/overlay.dart | 2 +- lib/widgets/navigation/drawer/app_drawer.dart | 2 +- .../settings/privacy/access_grants_page.dart | 2 +- lib/widgets/stats/mime_donut.dart | 2 +- .../viewer/info/metadata/metadata_section.dart | 2 +- .../info/metadata/metadata_thumbnail.dart | 2 +- lib/widgets/viewer/source_viewer_page.dart | 2 +- lib/widgets/viewer/visual/raster.dart | 4 ++-- lib/widgets/viewer/visual/vector.dart | 2 +- 14 files changed, 23 insertions(+), 23 deletions(-) diff --git a/lib/widgets/collection/grid/headers/any.dart b/lib/widgets/collection/grid/headers/any.dart index 645c33b2e..c3949add9 100644 --- a/lib/widgets/collection/grid/headers/any.dart +++ b/lib/widgets/collection/grid/headers/any.dart @@ -33,7 +33,7 @@ class CollectionSectionHeader extends StatelessWidget { height: height, child: header, ) - : const SizedBox.shrink(); + : const SizedBox(); } Widget? _buildHeader(BuildContext context) { diff --git a/lib/widgets/common/map/leaflet/map.dart b/lib/widgets/common/map/leaflet/map.dart index d0c60933f..1e3f39ca9 100644 --- a/lib/widgets/common/map/leaflet/map.dart +++ b/lib/widgets/common/map/leaflet/map.dart @@ -203,7 +203,7 @@ class _EntryLeafletMapState extends State> with TickerProv case EntryMapStyle.stamenWatercolor: return const StamenWatercolorLayer(); default: - return const SizedBox.shrink(); + return const SizedBox(); } } diff --git a/lib/widgets/debug/android_codecs.dart b/lib/widgets/debug/android_codecs.dart index bba35f549..054e4a7d3 100644 --- a/lib/widgets/debug/android_codecs.dart +++ b/lib/widgets/debug/android_codecs.dart @@ -36,7 +36,7 @@ class _DebugAndroidCodecSectionState extends State wit future: _loader, builder: (context, snapshot) { if (snapshot.hasError) return Text(snapshot.error.toString()); - if (snapshot.connectionState != ConnectionState.done) return const SizedBox.shrink(); + if (snapshot.connectionState != ConnectionState.done) return const SizedBox(); final codecs = snapshot.data!.map((codec) { return codec.map((k, v) => MapEntry(k.toString(), v.toString())); }).toList() diff --git a/lib/widgets/debug/android_dirs.dart b/lib/widgets/debug/android_dirs.dart index fd92c851e..d4abc67ae 100644 --- a/lib/widgets/debug/android_dirs.dart +++ b/lib/widgets/debug/android_dirs.dart @@ -34,7 +34,7 @@ class _DebugAndroidDirSectionState extends State with Au future: _loader, builder: (context, snapshot) { if (snapshot.hasError) return Text(snapshot.error.toString()); - if (snapshot.connectionState != ConnectionState.done) return const SizedBox.shrink(); + if (snapshot.connectionState != ConnectionState.done) return const SizedBox(); final data = SplayTreeMap.of(snapshot.data!.map((k, v) => MapEntry(k.toString(), v?.toString() ?? 'null'))); return InfoRowGroup(info: data); }, diff --git a/lib/widgets/debug/database.dart b/lib/widgets/debug/database.dart index 596eacdcd..906277ceb 100644 --- a/lib/widgets/debug/database.dart +++ b/lib/widgets/debug/database.dart @@ -50,7 +50,7 @@ class _DebugAppDatabaseSectionState extends State with builder: (context, snapshot) { if (snapshot.hasError) return Text(snapshot.error.toString()); - if (snapshot.connectionState != ConnectionState.done) return const SizedBox.shrink(); + if (snapshot.connectionState != ConnectionState.done) return const SizedBox(); return Row( children: [ @@ -71,7 +71,7 @@ class _DebugAppDatabaseSectionState extends State with builder: (context, snapshot) { if (snapshot.hasError) return Text(snapshot.error.toString()); - if (snapshot.connectionState != ConnectionState.done) return const SizedBox.shrink(); + if (snapshot.connectionState != ConnectionState.done) return const SizedBox(); return Row( children: [ @@ -92,7 +92,7 @@ class _DebugAppDatabaseSectionState extends State with builder: (context, snapshot) { if (snapshot.hasError) return Text(snapshot.error.toString()); - if (snapshot.connectionState != ConnectionState.done) return const SizedBox.shrink(); + if (snapshot.connectionState != ConnectionState.done) return const SizedBox(); return Row( children: [ @@ -113,7 +113,7 @@ class _DebugAppDatabaseSectionState extends State with builder: (context, snapshot) { if (snapshot.hasError) return Text(snapshot.error.toString()); - if (snapshot.connectionState != ConnectionState.done) return const SizedBox.shrink(); + if (snapshot.connectionState != ConnectionState.done) return const SizedBox(); return Row( children: [ @@ -134,7 +134,7 @@ class _DebugAppDatabaseSectionState extends State with builder: (context, snapshot) { if (snapshot.hasError) return Text(snapshot.error.toString()); - if (snapshot.connectionState != ConnectionState.done) return const SizedBox.shrink(); + if (snapshot.connectionState != ConnectionState.done) return const SizedBox(); return Row( children: [ @@ -155,7 +155,7 @@ class _DebugAppDatabaseSectionState extends State with builder: (context, snapshot) { if (snapshot.hasError) return Text(snapshot.error.toString()); - if (snapshot.connectionState != ConnectionState.done) return const SizedBox.shrink(); + if (snapshot.connectionState != ConnectionState.done) return const SizedBox(); return Row( children: [ @@ -176,7 +176,7 @@ class _DebugAppDatabaseSectionState extends State with builder: (context, snapshot) { if (snapshot.hasError) return Text(snapshot.error.toString()); - if (snapshot.connectionState != ConnectionState.done) return const SizedBox.shrink(); + if (snapshot.connectionState != ConnectionState.done) return const SizedBox(); return Row( children: [ @@ -197,7 +197,7 @@ class _DebugAppDatabaseSectionState extends State with builder: (context, snapshot) { if (snapshot.hasError) return Text(snapshot.error.toString()); - if (snapshot.connectionState != ConnectionState.done) return const SizedBox.shrink(); + if (snapshot.connectionState != ConnectionState.done) return const SizedBox(); return Row( children: [ @@ -218,7 +218,7 @@ class _DebugAppDatabaseSectionState extends State with builder: (context, snapshot) { if (snapshot.hasError) return Text(snapshot.error.toString()); - if (snapshot.connectionState != ConnectionState.done) return const SizedBox.shrink(); + if (snapshot.connectionState != ConnectionState.done) return const SizedBox(); return Row( children: [ diff --git a/lib/widgets/debug/overlay.dart b/lib/widgets/debug/overlay.dart index b2984037b..6011989a5 100644 --- a/lib/widgets/debug/overlay.dart +++ b/lib/widgets/debug/overlay.dart @@ -18,7 +18,7 @@ class DebugTaskQueueOverlay extends StatelessWidget { child: StreamBuilder( stream: servicePolicy.queueStream, builder: (context, snapshot) { - if (snapshot.hasError) return const SizedBox.shrink(); + if (snapshot.hasError) return const SizedBox(); final queuedEntries = >[]; if (snapshot.hasData) { final state = snapshot.data!; diff --git a/lib/widgets/navigation/drawer/app_drawer.dart b/lib/widgets/navigation/drawer/app_drawer.dart index d049d767e..e88747b4c 100644 --- a/lib/widgets/navigation/drawer/app_drawer.dart +++ b/lib/widgets/navigation/drawer/app_drawer.dart @@ -204,7 +204,7 @@ class _AppDrawerState extends State { stream: source.eventBus.on(), builder: (context, snapshot) { final albums = settings.drawerAlbumBookmarks ?? AppDrawer.getDefaultAlbums(context); - if (albums.isEmpty) return const SizedBox.shrink(); + if (albums.isEmpty) return const SizedBox(); return Column( children: [ const Divider(), diff --git a/lib/widgets/settings/privacy/access_grants_page.dart b/lib/widgets/settings/privacy/access_grants_page.dart index 1176a8961..0edb980fc 100644 --- a/lib/widgets/settings/privacy/access_grants_page.dart +++ b/lib/widgets/settings/privacy/access_grants_page.dart @@ -40,7 +40,7 @@ class _StorageAccessPageState extends State { return Text(snapshot.error.toString()); } if (snapshot.connectionState != ConnectionState.done && _lastPaths == null) { - return const SizedBox.shrink(); + return const SizedBox(); } _lastPaths = snapshot.data!..sort(); if (_lastPaths!.isEmpty) { diff --git a/lib/widgets/stats/mime_donut.dart b/lib/widgets/stats/mime_donut.dart index 4aee3ade5..82066c751 100644 --- a/lib/widgets/stats/mime_donut.dart +++ b/lib/widgets/stats/mime_donut.dart @@ -42,7 +42,7 @@ class _MimeDonutState extends State with AutomaticKeepAliveClientMixi Widget build(BuildContext context) { super.build(context); - if (byMimeTypes.isEmpty) return const SizedBox.shrink(); + if (byMimeTypes.isEmpty) return const SizedBox(); final l10n = context.l10n; final locale = l10n.localeName; diff --git a/lib/widgets/viewer/info/metadata/metadata_section.dart b/lib/widgets/viewer/info/metadata/metadata_section.dart index 5bee4740c..6977f8eea 100644 --- a/lib/widgets/viewer/info/metadata/metadata_section.dart +++ b/lib/widgets/viewer/info/metadata/metadata_section.dart @@ -79,7 +79,7 @@ class _MetadataSectionSliverState extends State { builder: (context, metadata, child) { Widget content; if (metadata.isEmpty) { - content = const SizedBox.shrink(); + content = const SizedBox(); } else { final durations = context.watch(); content = Column( diff --git a/lib/widgets/viewer/info/metadata/metadata_thumbnail.dart b/lib/widgets/viewer/info/metadata/metadata_thumbnail.dart index 0bb79ee82..542b001eb 100644 --- a/lib/widgets/viewer/info/metadata/metadata_thumbnail.dart +++ b/lib/widgets/viewer/info/metadata/metadata_thumbnail.dart @@ -50,7 +50,7 @@ class _MetadataThumbnailsState extends State { ), ); } - return const SizedBox.shrink(); + return const SizedBox(); }); } } diff --git a/lib/widgets/viewer/source_viewer_page.dart b/lib/widgets/viewer/source_viewer_page.dart index 741dc0d1c..a545eb2f9 100644 --- a/lib/widgets/viewer/source_viewer_page.dart +++ b/lib/widgets/viewer/source_viewer_page.dart @@ -40,7 +40,7 @@ class _SourceViewerPageState extends State { future: _loader, builder: (context, snapshot) { if (snapshot.hasError) return Text(snapshot.error.toString()); - if (!snapshot.hasData) return const SizedBox.shrink(); + if (!snapshot.hasData) return const SizedBox(); final data = snapshot.data!; final source = data.length < maxCodeSize ? data : '${data.substring(0, maxCodeSize)}\n\n*** TRUNCATED ***'; diff --git a/lib/widgets/viewer/visual/raster.dart b/lib/widgets/viewer/visual/raster.dart index bcbc78a90..a7770966e 100644 --- a/lib/widgets/viewer/visual/raster.dart +++ b/lib/widgets/viewer/visual/raster.dart @@ -164,7 +164,7 @@ class _RasterImageViewState extends State { return ValueListenableBuilder( valueListenable: _fullImageLoaded, builder: (context, fullImageLoaded, child) { - if (fullImageLoaded) return const SizedBox.shrink(); + if (fullImageLoaded) return const SizedBox(); return Center( child: AspectRatio( @@ -196,7 +196,7 @@ class _RasterImageViewState extends State { child = ValueListenableBuilder( valueListenable: _fullImageLoaded, builder: (context, fullImageLoaded, child) { - if (!fullImageLoaded) return const SizedBox.shrink(); + if (!fullImageLoaded) return const SizedBox(); return CustomPaint( painter: CheckeredPainter( diff --git a/lib/widgets/viewer/visual/vector.dart b/lib/widgets/viewer/visual/vector.dart index 64ea730fb..02736fa30 100644 --- a/lib/widgets/viewer/visual/vector.dart +++ b/lib/widgets/viewer/visual/vector.dart @@ -138,7 +138,7 @@ class _VectorImageViewState extends State { return ValueListenableBuilder( valueListenable: _fullImageLoaded, builder: (context, fullImageLoaded, child) { - if (fullImageLoaded) return const SizedBox.shrink(); + if (fullImageLoaded) return const SizedBox(); return Center( child: AspectRatio(