minor fixes

This commit is contained in:
Thibault Deckers 2020-08-08 18:03:56 +09:00
parent 930ca0e1f0
commit a3543a7c69
5 changed files with 78 additions and 61 deletions

View file

@ -289,7 +289,7 @@ class ImageEntry {
); );
} }
} catch (exception, stack) { } catch (exception, stack) {
debugPrint('$runtimeType addAddressToMetadata failed with path=$path coordinates=$coordinates exception=$exception\n$stack'); debugPrint('$runtimeType locate failed with path=$path coordinates=$coordinates exception=$exception\n$stack');
} }
} }

View file

@ -36,7 +36,12 @@ class _CreateAlbumDialogState extends State<CreateAlbumDialog> {
Widget build(BuildContext context) { Widget build(BuildContext context) {
return AlertDialog( return AlertDialog(
title: Text('New Album'), title: Text('New Album'),
content: ListView( content: Container(
// workaround because the dialog tries
// to size itself to the content intrinsic size,
// but the `ListView` viewport does not have one
width: double.maxFinite,
child: ListView(
shrinkWrap: true, shrinkWrap: true,
children: [ children: [
if (_allVolumes.length > 1) ...[ if (_allVolumes.length > 1) ...[
@ -84,6 +89,7 @@ class _CreateAlbumDialogState extends State<CreateAlbumDialog> {
), ),
], ],
), ),
),
contentPadding: EdgeInsets.only(top: 20), contentPadding: EdgeInsets.only(top: 20),
actions: [ actions: [
FlatButton( FlatButton(

View file

@ -22,7 +22,12 @@ class _GroupCollectionDialogState extends State<GroupCollectionDialog> {
Widget build(BuildContext context) { Widget build(BuildContext context) {
return AlertDialog( return AlertDialog(
title: Text('Group'), title: Text('Group'),
content: ListView( content: Container(
// workaround because the dialog tries
// to size itself to the content intrinsic size,
// but the `ListView` viewport does not have one
width: double.maxFinite,
child: ListView(
shrinkWrap: true, shrinkWrap: true,
children: [ children: [
_buildRadioListTile(GroupFactor.album, 'By album'), _buildRadioListTile(GroupFactor.album, 'By album'),
@ -31,6 +36,7 @@ class _GroupCollectionDialogState extends State<GroupCollectionDialog> {
_buildRadioListTile(GroupFactor.none, 'Do not group'), _buildRadioListTile(GroupFactor.none, 'Do not group'),
], ],
), ),
),
contentPadding: EdgeInsets.only(top: 20), contentPadding: EdgeInsets.only(top: 20),
actions: [ actions: [
FlatButton( FlatButton(

View file

@ -22,7 +22,12 @@ class _SortCollectionDialogState extends State<SortCollectionDialog> {
Widget build(BuildContext context) { Widget build(BuildContext context) {
return AlertDialog( return AlertDialog(
title: Text('Sort'), title: Text('Sort'),
content: ListView( content: Container(
// workaround because the dialog tries
// to size itself to the content intrinsic size,
// but the `ListView` viewport does not have one
width: double.maxFinite,
child: ListView(
shrinkWrap: true, shrinkWrap: true,
children: [ children: [
_buildRadioListTile(SortFactor.date, 'By date'), _buildRadioListTile(SortFactor.date, 'By date'),
@ -30,6 +35,7 @@ class _SortCollectionDialogState extends State<SortCollectionDialog> {
_buildRadioListTile(SortFactor.name, 'By album & file name'), _buildRadioListTile(SortFactor.name, 'By album & file name'),
], ],
), ),
),
contentPadding: EdgeInsets.only(top: 20), contentPadding: EdgeInsets.only(top: 20),
actions: [ actions: [
FlatButton( FlatButton(

View file

@ -140,8 +140,7 @@ class _WelcomePageState extends State<WelcomePage> {
borderRadius: BorderRadius.circular(16), borderRadius: BorderRadius.circular(16),
child: Markdown( child: Markdown(
data: terms, data: terms,
// TODO TLAD make it selectable when this fix (in 1.18.0-6.0.pre) lands on stable: https://github.com/flutter/flutter/pull/54479 selectable: true,
selectable: false,
onTapLink: (url) async { onTapLink: (url) async {
if (await canLaunch(url)) { if (await canLaunch(url)) {
await launch(url); await launch(url);