minor changes

This commit is contained in:
Thibault Deckers 2021-03-29 09:26:11 +09:00
parent 0227325781
commit 9d2954d717
5 changed files with 6 additions and 8 deletions

View file

@ -52,7 +52,7 @@ extension ExtraEntryAction on EntryAction {
// in app actions
case EntryAction.toggleFavourite:
// different data depending on toggle state
return null;
return context.l10n.entryActionAddFavourite;
case EntryAction.delete:
return context.l10n.entryActionDelete;
case EntryAction.export:
@ -93,7 +93,7 @@ extension ExtraEntryAction on EntryAction {
// in app actions
case EntryAction.toggleFavourite:
// different data depending on toggle state
return null;
return AIcons.favourite;
case EntryAction.delete:
return AIcons.delete;
case EntryAction.export:

View file

@ -44,7 +44,7 @@ class AppShortcutService {
await platform.invokeMethod('pin', <String, dynamic>{
'label': label,
'iconBytes': iconBytes,
'filters': filters.map((filter) => filter.toJson()).toList(),
'filters': filters.where((filter) => filter != null).map((filter) => filter.toJson()).toList(),
});
} on PlatformException catch (e) {
debugPrint('pin failed with code=${e.code}, exception=${e.message}, details=${e.details}');

View file

@ -367,7 +367,7 @@ class _CollectionAppBarState extends State<CollectionAppBar> with SingleTickerPr
if (name == null || name.isEmpty) return;
unawaited(AppShortcutService.pin(name, coverEntry, collection.filters));
unawaited(AppShortcutService.pin(name, coverEntry, filters));
}
void _goToSearch() {

View file

@ -10,10 +10,9 @@ class OverlayButton extends StatelessWidget {
const OverlayButton({
Key key,
@required this.scale,
this.scale = kAlwaysCompleteAnimation,
@required this.child,
}) : assert(scale != null),
super(key: key);
}) : super(key: key);
@override
Widget build(BuildContext context) {

View file

@ -94,7 +94,6 @@ class _PanoramaPageState extends State<PanoramaPage> {
return Padding(
padding: EdgeInsets.all(8) + EdgeInsets.only(right: mqPadding.right, bottom: mqPadding.bottom),
child: OverlayButton(
scale: kAlwaysCompleteAnimation,
child: ValueListenableBuilder<SensorControl>(
valueListenable: _sensorControl,
builder: (context, sensorControl, child) {