From 121dfe98d3b9f03d07e4fbd93f7c0654f727cf99 Mon Sep 17 00:00:00 2001 From: Thibault Deckers Date: Sat, 8 Aug 2020 22:10:52 +0900 Subject: [PATCH 1/3] CI: added quality check on develop --- .github/workflows/check.yml | 31 +++++++++++++++++++++ .github/workflows/{main.yml => release.yml} | 0 2 files changed, 31 insertions(+) create mode 100644 .github/workflows/check.yml rename .github/workflows/{main.yml => release.yml} (100%) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml new file mode 100644 index 000000000..02e6954db --- /dev/null +++ b/.github/workflows/check.yml @@ -0,0 +1,31 @@ +name: Quality check + +on: + push: + branches: + - develop + +jobs: + build: + name: Check code quality. + runs-on: ubuntu-latest + steps: + - uses: subosito/flutter-action@v1 + with: + channel: 'stable' + + - name: Clone the repository. + uses: actions/checkout@v2 + + - name: Get packages for the Flutter project. + run: flutter pub get + + - name: Update the flutter version file. + working-directory: ${{ github.workspace }}/scripts + run: ./update_flutter_version.sh + + - name: Static analysis. + run: flutter analyze + + - name: Unit tests. + run: flutter test diff --git a/.github/workflows/main.yml b/.github/workflows/release.yml similarity index 100% rename from .github/workflows/main.yml rename to .github/workflows/release.yml From b98f4d4e1d9ded967960dc0f32c579bae968115f Mon Sep 17 00:00:00 2001 From: Thibault Deckers Date: Sat, 8 Aug 2020 22:14:24 +0900 Subject: [PATCH 2/3] format & fixed static analysis issue --- lib/services/metadata_service.dart | 1 + lib/widgets/album/grid/header_generic.dart | 3 +-- .../common/action_delegates/selection_action_delegate.dart | 1 - .../common/data_providers/media_store_collection_provider.dart | 1 + 4 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/services/metadata_service.dart b/lib/services/metadata_service.dart index cbee8a679..83cdc40aa 100644 --- a/lib/services/metadata_service.dart +++ b/lib/services/metadata_service.dart @@ -48,6 +48,7 @@ class MetadataService { } return null; } + return background ? servicePolicy.call( call, diff --git a/lib/widgets/album/grid/header_generic.dart b/lib/widgets/album/grid/header_generic.dart index 59bbc8163..645c8c517 100644 --- a/lib/widgets/album/grid/header_generic.dart +++ b/lib/widgets/album/grid/header_generic.dart @@ -86,8 +86,7 @@ class SectionHeader extends StatelessWidget { // force a higher first line to match leading icon/selector dimension style: TextStyle(height: 2.3 * textScaleFactor), ), // 23 hair spaces match a width of 40.0 - if (hasTrailing) - TextSpan(text: '\u200A' * 17), + if (hasTrailing) TextSpan(text: '\u200A' * 17), TextSpan( text: text, style: Constants.titleTextStyle, diff --git a/lib/widgets/common/action_delegates/selection_action_delegate.dart b/lib/widgets/common/action_delegates/selection_action_delegate.dart index f753cab5f..0846ce862 100644 --- a/lib/widgets/common/action_delegates/selection_action_delegate.dart +++ b/lib/widgets/common/action_delegates/selection_action_delegate.dart @@ -8,7 +8,6 @@ import 'package:aves/model/source/collection_lens.dart'; import 'package:aves/model/source/collection_source.dart'; import 'package:aves/services/android_app_service.dart'; import 'package:aves/services/image_file_service.dart'; -import 'package:aves/utils/constants.dart'; import 'package:aves/utils/durations.dart'; import 'package:aves/widgets/album/app_bar.dart'; import 'package:aves/widgets/album/empty.dart'; diff --git a/lib/widgets/common/data_providers/media_store_collection_provider.dart b/lib/widgets/common/data_providers/media_store_collection_provider.dart index 62bf42636..a2ecb86e1 100644 --- a/lib/widgets/common/data_providers/media_store_collection_provider.dart +++ b/lib/widgets/common/data_providers/media_store_collection_provider.dart @@ -56,6 +56,7 @@ class MediaStoreSource extends CollectionSource { addAll(pendingNewEntries); pendingNewEntries.clear(); } + ImageFileService.getImageEntries(knownEntryMap).listen( (entry) { pendingNewEntries.add(entry); From f5da9e3ab9142cd7a7431916e0fce5706f654868 Mon Sep 17 00:00:00 2001 From: Thibault Deckers Date: Sat, 8 Aug 2020 22:15:33 +0900 Subject: [PATCH 3/3] version bump --- pubspec.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pubspec.yaml b/pubspec.yaml index b24d80597..677b3a265 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -11,7 +11,7 @@ description: A new Flutter application. # In iOS, build-name is used as CFBundleShortVersionString while build-number used as CFBundleVersion. # Read more about iOS versioning at # https://developer.apple.com/library/archive/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html -version: 1.1.3+15 +version: 1.1.4+16 # video_player (as of v0.10.8+2, backed by ExoPlayer): # - does not support content URIs (by default, but trivial by fork)