Fabio/aves
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

minor

Browse source
This commit is contained in:
Thibault Deckers 2023-04-18 19:40:16 +02:00
parent 53d758ccbb
commit 94af48a97f
4 changed files with 15 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/model/entry/extensions/metadata_edition.dart
View file

@ -27,7 +27,7 @@ extension ExtraAvesEntryMetadataEdition on AvesEntry {
final appliedModifier = await _applyDateModifierToEntry(userModifier); final appliedModifier = await _applyDateModifierToEntry(userModifier);
if (appliedModifier == null) { if (appliedModifier == null) {
if (!isMissingAtPath && userModifier.action != DateEditAction.copyField) { if (isValid && userModifier.action != DateEditAction.copyField) {
await reportService.recordError('failed to get date for modifier=$userModifier, entry=$this', null); await reportService.recordError('failed to get date for modifier=$userModifier, entry=$this', null);
} }
return {}; return {};

2
lib/model/entry/extensions/props.dart
View file

@ -12,6 +12,8 @@ import 'package:aves/theme/text.dart';
import 'package:aves/utils/android_file_utils.dart'; import 'package:aves/utils/android_file_utils.dart';
extension ExtraAvesEntryProps on AvesEntry { extension ExtraAvesEntryProps on AvesEntry {
bool get isValid => !isMissingAtPath && sizeBytes != 0 && width > 0 && height > 0;
// type // type
String get mimeTypeAnySubtype => mimeType.replaceAll(RegExp('/.*'), '/*'); String get mimeTypeAnySubtype => mimeType.replaceAll(RegExp('/.*'), '/*');

2
lib/services/metadata/metadata_edit_service.dart
View file

@ -123,7 +123,7 @@ class PlatformMetadataEditService implements MetadataEditService {
} }
Future<void> _processPlatformException(AvesEntry entry, PlatformException e, StackTrace stack) async { Future<void> _processPlatformException(AvesEntry entry, PlatformException e, StackTrace stack) async {
if (!entry.isMissingAtPath) { if (entry.isValid) {
final code = e.code; final code = e.code;
if (code.endsWith('mp4largemoov')) { if (code.endsWith('mp4largemoov')) {
await reportService.recordError(_Mp4LargeMoovException(code: e.code, message: e.message, details: e.details, stacktrace: e.stacktrace), stack); await reportService.recordError(_Mp4LargeMoovException(code: e.code, message: e.message, details: e.details, stacktrace: e.stacktrace), stack);

22
lib/services/metadata/metadata_fetch_service.dart
View file

@ -58,7 +58,7 @@ class PlatformMetadataFetchService implements MetadataFetchService {
}); });
if (result != null) return result as Map; if (result != null) return result as Map;
} on PlatformException catch (e, stack) { } on PlatformException catch (e, stack) {
if (!entry.isMissingAtPath) { if (entry.isValid) {
await reportService.recordError(e, stack); await reportService.recordError(e, stack);
} }
} }
@ -96,7 +96,7 @@ class PlatformMetadataFetchService implements MetadataFetchService {
result['id'] = entry.id; result['id'] = entry.id;
return CatalogMetadata.fromMap(result); return CatalogMetadata.fromMap(result);
} on PlatformException catch (e, stack) { } on PlatformException catch (e, stack) {
if (!entry.isMissingAtPath) { if (entry.isValid) {
await reportService.recordError(e, stack); await reportService.recordError(e, stack);
} }
} }
@ -124,7 +124,7 @@ class PlatformMetadataFetchService implements MetadataFetchService {
}) as Map; }) as Map;
return OverlayMetadata.fromMap(result); return OverlayMetadata.fromMap(result);
} on PlatformException catch (e, stack) { } on PlatformException catch (e, stack) {
if (!entry.isMissingAtPath) { if (entry.isValid) {
await reportService.recordError(e, stack); await reportService.recordError(e, stack);
} }
} }
@ -141,7 +141,7 @@ class PlatformMetadataFetchService implements MetadataFetchService {
}) as Map; }) as Map;
return GeoTiffInfo.fromMap(result); return GeoTiffInfo.fromMap(result);
} on PlatformException catch (e, stack) { } on PlatformException catch (e, stack) {
if (!entry.isMissingAtPath) { if (entry.isValid) {
await reportService.recordError(e, stack); await reportService.recordError(e, stack);
} }
} }
@ -166,7 +166,7 @@ class PlatformMetadataFetchService implements MetadataFetchService {
} }
return MultiPageInfo.fromPageMaps(entry, pageMaps); return MultiPageInfo.fromPageMaps(entry, pageMaps);
} on PlatformException catch (e, stack) { } on PlatformException catch (e, stack) {
if (!entry.isMissingAtPath) { if (entry.isValid) {
await reportService.recordError(e, stack); await reportService.recordError(e, stack);
} }
} }
@ -186,7 +186,7 @@ class PlatformMetadataFetchService implements MetadataFetchService {
}) as Map; }) as Map;
return PanoramaInfo.fromMap(result); return PanoramaInfo.fromMap(result);
} on PlatformException catch (e, stack) { } on PlatformException catch (e, stack) {
if (!entry.isMissingAtPath) { if (entry.isValid) {
await reportService.recordError(e, stack); await reportService.recordError(e, stack);
} }
} }
@ -202,7 +202,7 @@ class PlatformMetadataFetchService implements MetadataFetchService {
}); });
if (result != null) return (result as List).cast<Map>().map((fields) => fields.cast<String, dynamic>()).toList(); if (result != null) return (result as List).cast<Map>().map((fields) => fields.cast<String, dynamic>()).toList();
} on PlatformException catch (e, stack) { } on PlatformException catch (e, stack) {
if (!entry.isMissingAtPath) { if (entry.isValid) {
await reportService.recordError(e, stack); await reportService.recordError(e, stack);
} }
} }
@ -219,7 +219,7 @@ class PlatformMetadataFetchService implements MetadataFetchService {
}); });
if (result != null) return AvesXmp.fromList((result as List).cast<String>()); if (result != null) return AvesXmp.fromList((result as List).cast<String>());
} on PlatformException catch (e, stack) { } on PlatformException catch (e, stack) {
if (!entry.isMissingAtPath) { if (entry.isValid) {
await reportService.recordError(e, stack); await reportService.recordError(e, stack);
} }
} }
@ -254,7 +254,7 @@ class PlatformMetadataFetchService implements MetadataFetchService {
'prop': prop, 'prop': prop,
}); });
} on PlatformException catch (e, stack) { } on PlatformException catch (e, stack) {
if (!entry.isMissingAtPath) { if (entry.isValid) {
await reportService.recordError(e, stack); await reportService.recordError(e, stack);
} }
} }
@ -274,7 +274,7 @@ class PlatformMetadataFetchService implements MetadataFetchService {
return dateTimeFromMillis(result, isUtc: false); return dateTimeFromMillis(result, isUtc: false);
} }
} on PlatformException catch (e, stack) { } on PlatformException catch (e, stack) {
if (!entry.isMissingAtPath) { if (entry.isValid) {
await reportService.recordError(e, stack); await reportService.recordError(e, stack);
} }
} }
@ -290,7 +290,7 @@ class PlatformMetadataFetchService implements MetadataFetchService {
'sizeBytes': entry.sizeBytes, 'sizeBytes': entry.sizeBytes,
}); });
} on PlatformException catch (e, stack) { } on PlatformException catch (e, stack) {
if (!entry.isMissingAtPath) { if (entry.isValid) {
await reportService.recordError(e, stack); await reportService.recordError(e, stack);
} }
} }