minor changes

This commit is contained in:
Thibault Deckers 2021-06-21 15:24:17 +09:00
parent 2ca67f403d
commit 867447832a
3 changed files with 4 additions and 6 deletions

View file

@ -43,15 +43,13 @@ abstract class CollectionSource with SourceBase, AlbumMixin, LocationMixin, TagM
final Set<AvesEntry> _rawEntries = {};
// TODO TLAD use `Set.unmodifiable()` when possible
Set<AvesEntry> get allEntries => Set.of(_rawEntries);
Set<AvesEntry> get allEntries => Set.unmodifiable(_rawEntries);
Set<AvesEntry>? _visibleEntries;
@override
Set<AvesEntry> get visibleEntries {
// TODO TLAD use `Set.unmodifiable()` when possible
_visibleEntries ??= Set.of(_applyHiddenFilters(_rawEntries));
_visibleEntries ??= Set.unmodifiable(_applyHiddenFilters(_rawEntries));
return _visibleEntries!;
}

View file

@ -87,7 +87,7 @@ class SectionHeader extends StatelessWidget {
}
}
// TODO TLAD cache header extent computation?
// TODO TLAD [perf] cache header extent computation?
static double getPreferredHeight({
required BuildContext context,
required double maxWidth,

View file

@ -2,7 +2,7 @@ import 'package:aves/widgets/aves_app.dart';
import 'package:flutter_test/flutter_test.dart';
void main() {
testWidgets('TODO TLAD', (tester) async {
testWidgets('widget test', (tester) async {
await tester.pumpWidget(AvesApp());
});
}