From 2f8d870811cfc4a3ad7c51a56faf85629b185af6 Mon Sep 17 00:00:00 2001 From: Thibault Deckers Date: Tue, 30 Apr 2024 23:05:36 +0200 Subject: [PATCH] minor --- plugins/aves_video_mpv/lib/src/controller.dart | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/plugins/aves_video_mpv/lib/src/controller.dart b/plugins/aves_video_mpv/lib/src/controller.dart index bd47ffeb9..65265323c 100644 --- a/plugins/aves_video_mpv/lib/src/controller.dart +++ b/plugins/aves_video_mpv/lib/src/controller.dart @@ -128,6 +128,7 @@ class MpvVideoController extends AvesVideoController { if (path != null) { final videoBasename = _pContext.basenameWithoutExtension(path); // list subtitle files in the same directory + // some files may be visible to the app (e.g. SRT) while others may not (e.g. SUB, VTT) _subscriptions.add(File(path).parent.list().where((v) => v is File && _isSubtitle(v.path)).listen((v) { final subtitleBasename = _pContext.basename(v.path); if (subtitleBasename.startsWith(videoBasename)) { @@ -403,12 +404,7 @@ class MpvVideoController extends AvesVideoController { } } - static bool _isSubtitle(String path) { - switch (_pContext.extension(path)) { - case '.srt': - return true; - default: - return false; - } - } + static const Set _subtitleExtensions = {'.srt', '.sub', '.vtt'}; + + static bool _isSubtitle(String path) => _subtitleExtensions.contains(_pContext.extension(path)); }