Fabio/aves
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fixed app album chip outline color resetting when returning to a page with the first chip for this album

Browse source
This commit is contained in:
Thibault Deckers 2020-09-10 22:41:54 +09:00
parent c19b266e76
commit 1894dd2562
1 changed files with 15 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
lib/widgets/common/aves_filter_chip.dart
View file

@ -40,6 +40,7 @@ class AvesFilterChip extends StatefulWidget {
class _AvesFilterChipState extends State<AvesFilterChip> { class _AvesFilterChipState extends State<AvesFilterChip> {
Future<Color> _colorFuture; Future<Color> _colorFuture;
Color _outlineColor;
bool _tapped; bool _tapped;
CollectionFilter get filter => widget.filter; CollectionFilter get filter => widget.filter;
@ -60,7 +61,16 @@ class _AvesFilterChipState extends State<AvesFilterChip> {
} }
} }
void _initColorLoader() => _colorFuture = filter.color(context); void _initColorLoader() {
// For app albums, `filter.color` yields a regular async `Future` the first time
// but it yields a `SynchronousFuture` when called again on a known album.
// This works fine to avoid a frame with no Future data, for new widgets.
// However, when the user moves away and back to a page with a chip using the async future,
// the existing widget FutureBuilder cycles again from the start, with a frame in `waiting` state and no data.
// So we save the result of the Future to a local variable because of this specific case.
_colorFuture = filter.color(context);
_outlineColor = Colors.transparent;
}
@override @override
Widget build(BuildContext context) { Widget build(BuildContext context) {
@ -160,11 +170,13 @@ class _AvesFilterChipState extends State<AvesFilterChip> {
child: FutureBuilder<Color>( child: FutureBuilder<Color>(
future: _colorFuture, future: _colorFuture,
builder: (context, snapshot) { builder: (context, snapshot) {
final outlineColor = snapshot.hasData ? snapshot.data : Colors.transparent; if (snapshot.hasData) {
_outlineColor = snapshot.data;
}
return DecoratedBox( return DecoratedBox(
decoration: BoxDecoration( decoration: BoxDecoration(
border: Border.all( border: Border.all(
color: outlineColor, color: _outlineColor,
width: AvesFilterChip.outlineWidth, width: AvesFilterChip.outlineWidth,
), ),
borderRadius: borderRadius, borderRadius: borderRadius,