Alexander Capehart
2ee9556564
musikr: integrate metadatajni into app
...
Just extracts title rn while I still work on the ffi.
2025-02-08 11:56:28 -07:00
Alexander Capehart
729a3c3273
musikr: basic taglib rust shim
2025-02-08 10:15:36 -07:00
Alexander Capehart
534f06d7e1
musikr: link to library
2025-02-06 14:46:29 -07:00
Alexander Capehart
ed0abb661c
musikr: implement taglib build step for rust module
2025-02-04 17:02:59 -07:00
Alexander Capehart
6216e1d591
musikr: move taglib to new rust module
2025-02-04 16:20:48 -07:00
Alexander Capehart
d6cf484d61
musikr: init rust metadata jni library
2025-02-04 16:15:17 -07:00
Alexander Capehart
df68768842
musikr.metadata: handle case w/no mp4 covers
...
Otherwise could have triggered an exception.
2025-01-31 14:41:44 -07:00
Alexander Capehart
72ffac4209
musikr: reformat
2025-01-31 13:45:18 -07:00
Alexander Capehart
ee7e63d1dc
musikr: stop possible use-after-free in metabuild
2025-01-31 13:41:23 -07:00
Alexander Capehart
2e4b6681d1
build: bump to v4.0.0-dev5
2025-01-30 12:50:10 -07:00
Alexander Capehart
a0c82ac812
musikr: reformat
2025-01-30 09:38:38 -07:00
Alexander Capehart
e78fde44e0
Revert "musikr: use channel-based pipeline"
...
This reverts commit 7c8863bd3a
.
2025-01-30 09:30:38 -07:00
Alexander Capehart
7880c777ba
musikr: fix inputstream memory leak
...
Apparently allocating the bytes on the JVM side of the taglib parser
will wind up leaking memory due to a bugged cache in ByteBuffer.
Instead, allocate the bytes in native, wrap it into a ByteBuffer, and
then pass it upwards into NativeInputStream. This seems to fix the
leak.
2025-01-30 09:29:26 -07:00
Alexander Capehart
7c8863bd3a
musikr: use channel-based pipeline
...
Much more repeated code, but no more memory leaks.
2025-01-29 15:31:48 -07:00
Alexander Capehart
97bd259728
musikr: handle duplicate playlist songs in graph
...
Accidentally flattened these out during graphing.
2025-01-22 12:57:11 -07:00
Alexander Capehart
9685f3cf51
musikr: fix broken jni build
2025-01-20 11:40:15 -07:00
Alexander Capehart
9d22cc37b8
musikr: report invalid songs in pipeline
...
Avoids the bar getting "stuck"
2025-01-20 11:39:47 -07:00
Alexander Capehart
d49286981c
musikr: improve native error handling
...
Not an ideal error reporting system, but for the purposes of getting
4.0.0 out as fast as possible it will do.
2025-01-20 11:26:41 -07:00
Alexander Capehart
0785711cd6
musikr.tag: handle slash positions in xiph
...
Resolves #965 .
2025-01-18 20:32:28 -07:00
Alexander Capehart
a0e10ef8dd
musikr: implement raii jni classes
...
This should hopefully mitigate the memory leak problems unless I forget
to transfer over ref ownership to the corresponding class. Analyzed
memory use on load and it looks like the JVM is able to reclaim
everything extracted by the native code, so I should hopefully be fine.
2025-01-18 19:52:05 -07:00
Alexander Capehart
1bf44eba91
musikr: fix memory leaks
2025-01-18 17:21:14 -07:00
Alexander Capehart
3aae8ea534
musikr: bubblewrap nativeinputstream
...
Try to avoid exceptions cascading and bringing down the app.
2025-01-18 09:58:05 -07:00
Alexander Capehart
4d704e86a6
Revert "musikr: bubblewrap jvminputstream"
...
This reverts commit b6d80189ca
.
2025-01-15 11:44:29 -07:00
Alexander Capehart
c9d4b01f9f
musikr: initial root documentation
2025-01-14 08:55:44 -07:00
Alexander Capehart
b6d80189ca
musikr: bubblewrap jvminputstream
...
Should help me ID some error.
2025-01-14 08:53:03 -07:00
Alexander Capehart
71aa887438
musikr.cache: bump version
2025-01-13 19:35:03 -07:00
Alexander Capehart
e6b326a571
musikr: clarify album added timestamp api
...
Same reasons, should be milliseconds
2025-01-09 19:31:48 -07:00
Alexander Capehart
ae6a0438be
musikr: clarify added/modified timestamp apis
...
Clearly indicate their new millisecond nature.
2025-01-09 19:30:32 -07:00
Alexander Capehart
8bd89c5967
musikr: ignore genre numbers of 255
2025-01-08 18:27:08 -07:00
Alexander Capehart
9b82b5aee0
build: bump to 4.0.0-dev3
2025-01-08 18:19:37 -07:00
Alexander Capehart
e0059e9dc0
musikr: reformat
2025-01-08 17:19:02 -07:00
Alexander Capehart
3d690eb637
musikr: fix graphing error w/certain link steps
...
I wasn't correctly linking genres, which would cascade to a dead vertex
down the line.
Will need better diagnostics here.
2025-01-08 17:17:05 -07:00
Alexander Capehart
0e34a28dfb
musikr: fix stream seeking
...
Foolishly changed offset sign in seek from end.
2025-01-08 15:49:49 -07:00
Alexander Capehart
8c3750778f
musikr: add id3v1 support
...
Forgot to go ahead and implement this.
2025-01-08 15:06:25 -07:00
Alexander Capehart
802e215482
musikr: remove extractstep debug logging
...
Not needed right now
2025-01-08 15:05:50 -07:00
Alexander Capehart
8c4b8dfb56
musikr: improve dead vertex error reporting
2025-01-08 12:53:04 -07:00
Alexander Capehart
58e0956cad
musikr: dont stop parsing mp4 atoms
...
I cannot believe I have made this mistake twice.
2025-01-08 11:31:52 -07:00
Alexander Capehart
e94b74edd4
musikr: do custom picture handling
...
TagLib's picture handling is inadequate for our use case.
2025-01-08 11:15:56 -07:00
Alexander Capehart
b3f4fdfb4a
build: bump version
...
Bump to version 4.0.0-dev2.
2025-01-08 10:37:03 -07:00
Alexander Capehart
e519e8f8be
musikr: handle null tags
2025-01-07 19:34:30 -07:00
Alexander Capehart
ed3e0845d6
musikr: more debug logging
...
Trying to track down this thorny segfault.
2025-01-07 18:31:59 -07:00
Alexander Capehart
7b9c14a118
musikr: add temp logging
2025-01-07 13:05:32 -07:00
Alexander Capehart
605800e9a5
musikr: handle possible null pointers in id3v2
2025-01-07 10:02:28 -07:00
Alexander Capehart
2b46774215
musikr: fix internal frame parsing
2025-01-06 14:12:24 -07:00
Alexander Capehart
1d84ba23b4
build: update submodules
2025-01-06 13:54:22 -07:00
Alexander Capehart
fdf71cedd2
musikr: fix formatting
2025-01-06 13:17:27 -07:00
Alexander Capehart
5e168860e7
musikr: bundle cleanup into api
...
Prevents as much footguns.
2025-01-06 13:16:31 -07:00
Alexander Capehart
b328a6ea03
musikr: add temp logging
...
To debug metadata issues.
2025-01-06 11:41:01 -07:00
Alexander Capehart
bbc4db156e
musikr: fix equality issues
2025-01-06 11:23:55 -07:00
Alexander Capehart
9952579cc4
musikr.tag: fix correction creating empty tag lists
2025-01-06 08:28:56 -07:00