From efb800ee6a8df68a64d1f381215bab3954caa0fd Mon Sep 17 00:00:00 2001 From: OxygenCobalt Date: Sun, 31 Oct 2021 19:52:59 -0600 Subject: [PATCH] playback: fix playback progress bug Fix an issue where I forgot to call executePendingBindings when updating progress, resulting in strange behavior with the progress bar. --- app/src/main/java/org/oxycblt/auxio/MainFragment.kt | 1 - .../java/org/oxycblt/auxio/playback/CompactPlaybackView.kt | 6 +----- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/app/src/main/java/org/oxycblt/auxio/MainFragment.kt b/app/src/main/java/org/oxycblt/auxio/MainFragment.kt index d4926dd95..89aea2c91 100644 --- a/app/src/main/java/org/oxycblt/auxio/MainFragment.kt +++ b/app/src/main/java/org/oxycblt/auxio/MainFragment.kt @@ -66,7 +66,6 @@ class MainFragment : Fragment(), PlaybackBarLayout.ActionCallback { binding.lifecycleOwner = viewLifecycleOwner // --- VIEWMODEL SETUP --- - binding.mainBarLayout.setActionCallback(this) binding.mainBarLayout.setSong(playbackModel.song.value) diff --git a/app/src/main/java/org/oxycblt/auxio/playback/CompactPlaybackView.kt b/app/src/main/java/org/oxycblt/auxio/playback/CompactPlaybackView.kt index 78d4dba71..974a90a85 100644 --- a/app/src/main/java/org/oxycblt/auxio/playback/CompactPlaybackView.kt +++ b/app/src/main/java/org/oxycblt/auxio/playback/CompactPlaybackView.kt @@ -84,6 +84,7 @@ class CompactPlaybackView @JvmOverloads constructor( fun setSong(song: Song) { binding.song = song + binding.executePendingBindings() } fun setPlaying(isPlaying: Boolean) { @@ -91,11 +92,6 @@ class CompactPlaybackView @JvmOverloads constructor( } fun setPosition(position: Long) { - if (binding.song == null) { - binding.playbackProgressBar.progress = 0 - return - } - binding.playbackProgressBar.progress = position.toInt() }