Fabio/Auxio
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

musikr: stop possible use-after-free in metabuild

Browse source
This commit is contained in:
Alexander Capehart 2025-01-31 13:41:23 -07:00
parent f9109b8a9c
commit ee7e63d1dc
No known key found for this signature in database
GPG key ID: 37DBE3621FE9AD47
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
musikr/src/main/cpp/JMetadataBuilder.cpp
View file

@ -208,8 +208,9 @@ jobject JMetadataBuilder::build() {
auto jMp4Map = mp4.getObject(); auto jMp4Map = mp4.getObject();
if (cover.has_value()) { if (cover.has_value()) {
JByteArrayRef jCoverArray { env, cover.value() }; JByteArrayRef jCoverArray { env, cover.value() };
return env->NewObject(*jMetadataClass, jMetadataInitMethod, **jId3v2Map, jobject result = env->NewObject(*jMetadataClass, jMetadataInitMethod, **jId3v2Map,
**jXiphMap, **jMp4Map, *jCoverArray, *jProperties); **jXiphMap, **jMp4Map, *jCoverArray, *jProperties);
return result;
} }
return env->NewObject(*jMetadataClass, jMetadataInitMethod, **jId3v2Map, return env->NewObject(*jMetadataClass, jMetadataInitMethod, **jId3v2Map,
**jXiphMap, **jMp4Map, nullptr, *jProperties); **jXiphMap, **jMp4Map, nullptr, *jProperties);