From e4aa409cbc7cec0e030f2ed9a79f99e547b29c00 Mon Sep 17 00:00:00 2001 From: Alexander Capehart Date: Fri, 3 Mar 2023 18:56:42 -0700 Subject: [PATCH] playback: add fragmented mp4 extractor Not adding this broke MP4-AAC files for some insane reason. Google devs try not to maintain two near-identical products with only slightly infuriating differences challenge (IMPOSSIBLE) Resolves #388. --- CHANGELOG.md | 4 ++++ .../main/java/org/oxycblt/auxio/music/AudioOnlyExtractors.kt | 2 ++ 2 files changed, 6 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9aa749ac9..7caf488d2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,10 @@ ## dev +#### What's Fixed +- Fixed MP4-AAC files not playing due to an accidental audio extractor +deletion + #### What's Improved - Accept `REPLAYGAIN_*` adjustment information on OPUS files alongside `R128_*` adjustments. diff --git a/app/src/main/java/org/oxycblt/auxio/music/AudioOnlyExtractors.kt b/app/src/main/java/org/oxycblt/auxio/music/AudioOnlyExtractors.kt index 3220e8ef9..97196dad1 100644 --- a/app/src/main/java/org/oxycblt/auxio/music/AudioOnlyExtractors.kt +++ b/app/src/main/java/org/oxycblt/auxio/music/AudioOnlyExtractors.kt @@ -21,6 +21,7 @@ import com.google.android.exoplayer2.extractor.ExtractorsFactory import com.google.android.exoplayer2.extractor.flac.FlacExtractor import com.google.android.exoplayer2.extractor.mkv.MatroskaExtractor import com.google.android.exoplayer2.extractor.mp3.Mp3Extractor +import com.google.android.exoplayer2.extractor.mp4.FragmentedMp4Extractor import com.google.android.exoplayer2.extractor.mp4.Mp4Extractor import com.google.android.exoplayer2.extractor.ogg.OggExtractor import com.google.android.exoplayer2.extractor.ts.AdtsExtractor @@ -36,6 +37,7 @@ object AudioOnlyExtractors : ExtractorsFactory { arrayOf( FlacExtractor(), WavExtractor(), + FragmentedMp4Extractor(), Mp4Extractor(), OggExtractor(), MatroskaExtractor(),