From e12c7cb4196f67b705fc63b2b6d28e58db9e0fab Mon Sep 17 00:00:00 2001 From: OxygenCobalt Date: Fri, 5 Aug 2022 09:58:20 -0600 Subject: [PATCH] ui: rework resource distribution Try to remove the weird config file and replace it with more conventional resource files in other places. --- .../java/org/oxycblt/auxio/MainActivity.kt | 3 + .../auxio/detail/DetailAppBarLayout.kt | 5 +- .../auxio/settings/SettingsListFragment.kt | 5 + .../layout-sw600dp/fragment_playback_bar.xml | 97 ------------------- app/src/main/res/layout/dialog_music_dirs.xml | 6 +- app/src/main/res/layout/dialog_tabs.xml | 4 +- app/src/main/res/layout/fragment_detail.xml | 3 +- .../main/res/layout/fragment_home_list.xml | 8 +- app/src/main/res/layout/fragment_queue.xml | 4 +- app/src/main/res/layout/fragment_search.xml | 3 +- app/src/main/res/layout/item_music_dir.xml | 2 +- .../styles_ui.xml | 2 +- .../main/res/values-sw840dp-land/config.xml | 4 - .../res/values-sw840dp-land/styles_ui.xml | 7 ++ app/src/main/res/values-v23/styles_core.xml | 4 + app/src/main/res/values-v31/config.xml | 4 - app/src/main/res/values-v31/styles_core.xml | 2 +- app/src/main/res/values-w640dp/config.xml | 4 - app/src/main/res/values-w640dp/styles_ui.xml | 7 ++ app/src/main/res/values/attrs.xml | 6 ++ app/src/main/res/values/config.xml | 6 -- app/src/main/res/values/ids.xml | 11 --- app/src/main/res/values/styles_core.xml | 5 +- app/src/main/res/values/styles_ui.xml | 12 ++- app/src/main/res/xml/prefs_main.xml | 1 - 25 files changed, 59 insertions(+), 156 deletions(-) delete mode 100644 app/src/main/res/layout-sw600dp/fragment_playback_bar.xml rename app/src/main/res/{values-sw640dp => values-sw600dp}/styles_ui.xml (76%) delete mode 100644 app/src/main/res/values-sw840dp-land/config.xml create mode 100644 app/src/main/res/values-sw840dp-land/styles_ui.xml delete mode 100644 app/src/main/res/values-v31/config.xml delete mode 100644 app/src/main/res/values-w640dp/config.xml create mode 100644 app/src/main/res/values-w640dp/styles_ui.xml delete mode 100644 app/src/main/res/values/config.xml delete mode 100644 app/src/main/res/values/ids.xml diff --git a/app/src/main/java/org/oxycblt/auxio/MainActivity.kt b/app/src/main/java/org/oxycblt/auxio/MainActivity.kt index 05fdf113a..8e834e3fe 100644 --- a/app/src/main/java/org/oxycblt/auxio/MainActivity.kt +++ b/app/src/main/java/org/oxycblt/auxio/MainActivity.kt @@ -44,6 +44,9 @@ import org.oxycblt.auxio.util.systemBarInsetsCompat * * TODO: Add multi-select * + * LEFT-OFF: Add RecyclerView styles, queue issue is caused by tiny scroll and then replace op, not + * enough to change scroll apparently + * * @author OxygenCobalt */ class MainActivity : AppCompatActivity() { diff --git a/app/src/main/java/org/oxycblt/auxio/detail/DetailAppBarLayout.kt b/app/src/main/java/org/oxycblt/auxio/detail/DetailAppBarLayout.kt index 91d1436ed..6305f68d1 100644 --- a/app/src/main/java/org/oxycblt/auxio/detail/DetailAppBarLayout.kt +++ b/app/src/main/java/org/oxycblt/auxio/detail/DetailAppBarLayout.kt @@ -111,8 +111,7 @@ constructor(context: Context, attrs: AttributeSet? = null, @AttrRes defStyleAttr this.titleAnimator = ValueAnimator.ofFloat(from, to).apply { addUpdateListener { titleView?.alpha = it.animatedValue as Float } - duration = - resources.getInteger(R.integer.detail_app_bar_title_anim_duration).toLong() + duration = TOOLBAR_FADE_DURATION start() } } @@ -143,6 +142,8 @@ constructor(context: Context, attrs: AttributeSet? = null, @AttrRes defStyleAttr } companion object { + private const val TOOLBAR_FADE_DURATION = 150L + private val TOOLBAR_TITLE_TEXT_FIELD: Field by lazyReflectedField(Toolbar::class, "mTitleTextView") } diff --git a/app/src/main/java/org/oxycblt/auxio/settings/SettingsListFragment.kt b/app/src/main/java/org/oxycblt/auxio/settings/SettingsListFragment.kt index 6c1f1f475..a6f8387ce 100644 --- a/app/src/main/java/org/oxycblt/auxio/settings/SettingsListFragment.kt +++ b/app/src/main/java/org/oxycblt/auxio/settings/SettingsListFragment.kt @@ -17,6 +17,7 @@ package org.oxycblt.auxio.settings +import android.os.Build import android.os.Bundle import android.view.View import androidx.annotation.DrawableRes @@ -161,6 +162,10 @@ class SettingsListFragment : PreferenceFragmentCompat() { preference.apply { when (key) { context.getString(R.string.set_key_theme) -> { + // Android 12 is the first version I deem to have universal dark and light + // mode toggles. No need for our setting. + isVisible = Build.VERSION.SDK_INT < Build.VERSION_CODES.S + onPreferenceChangeListener = Preference.OnPreferenceChangeListener { _, value -> AppCompatDelegate.setDefaultNightMode(value as Int) diff --git a/app/src/main/res/layout-sw600dp/fragment_playback_bar.xml b/app/src/main/res/layout-sw600dp/fragment_playback_bar.xml deleted file mode 100644 index d9f1dcb58..000000000 --- a/app/src/main/res/layout-sw600dp/fragment_playback_bar.xml +++ /dev/null @@ -1,97 +0,0 @@ - - - - - - - - - - - - - -